Skip to content

Make SetABTests Island server safe - #9162

Merged
mxdvl merged 1 commit into
mainfrom
mxdvl/islands-ssr/SetABTests
Oct 17, 2023
Merged

mxdvl merged 1 commit into
mainfrom
mxdvl/islands-ssr/SetABTests

Conversation

@mxdvl

@mxdvl mxdvl commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

What does this change?

Wrap all client-side logic in a useEffect hook.

Test that it will render on a server

Why?

Components should be able to run in any context.

Screenshots

N/A

@mxdvl
mxdvl requested a review from a team as a code owner October 17, 2023 14:58
- wrap all client-side logic in `useEffect`
@mxdvl
mxdvl force-pushed the mxdvl/islands-ssr/SetABTests branch from ed86d85 to cf674b9 Compare October 17, 2023 15:04
@github-actions

github-actions Bot commented Oct 17, 2023 •

Copy link
Copy Markdown

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Oct 17, 2023
@mxdvl
mxdvl merged commit 10ad42d into main Oct 17, 2023
@mxdvl
mxdvl deleted the mxdvl/islands-ssr/SetABTests branch October 17, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering run_chromatic Runs chromatic when label is applied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants