Repository navigation
Make SetABTests Island server safe - #9162
Merged
Merged
Conversation
abeddow91
approved these changes
Oct 17, 2023
- wrap all client-side logic in `useEffect`
mxdvl
force-pushed
the
mxdvl/islands-ssr/SetABTests
branch
from
October 17, 2023 15:04
ed86d85 to
cf674b9
Compare
|
Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Wrap all client-side logic in a
useEffecthook.Test that it will render on a server
Why?
Components should be able to run in any context.
Screenshots
N/A