Make `SignInGateSelector` Island server safe by mxdvl · Pull Request #9367 · guardian/dotcom-rendering

mxdvl · 2023-10-31T11:11:58Z

What does this change?

Use hooks to make the SignInGateSelector run in a server context.

Looping in @guardian/identity for visibility.

Why?

No assumption should be made about where components are run

Split out from 🏝️ All islands must be rendered on the server for maximum safety and consistency 🤗 #8991 for easier review
Enables the work from Islands can no longer be “client-side only” #8948 to proceed safely.

Screenshots

N/A

github-actions · 2023-10-31T11:20:26Z

Size Change: +98 B (0%)

Total Size: 698 kB

ℹ️ View Unchanged

Filename	Size	Change
`dotcom-rendering/dist/1076.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/1149.web.********************.js`	2.92 kB	0 B
`dotcom-rendering/dist/1226.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/1244.web.********************.js`	865 B	0 B
`dotcom-rendering/dist/1294.web.********************.js`	5.36 kB	0 B
`dotcom-rendering/dist/1406.web.********************.js`	5.09 kB	0 B
`dotcom-rendering/dist/1418.web.********************.js`	10.1 kB	0 B
`dotcom-rendering/dist/1465.web.********************.js`	3.32 kB	0 B
`dotcom-rendering/dist/1486.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/1521.web.********************.js`	5.48 kB	0 B
`dotcom-rendering/dist/1659.web.********************.js`	518 B	0 B
`dotcom-rendering/dist/1848.web.********************.js`	644 B	0 B
`dotcom-rendering/dist/1987.web.********************.js`	3.12 kB	0 B
`dotcom-rendering/dist/1997.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/2071.web.********************.js`	745 B	0 B
`dotcom-rendering/dist/21.web.********************.js`	758 B	0 B
`dotcom-rendering/dist/2113.web.********************.js`	29.6 kB	0 B
`dotcom-rendering/dist/2126.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/2133.web.********************.js`	4.46 kB	0 B
`dotcom-rendering/dist/2201.web.********************.js`	778 B	0 B
`dotcom-rendering/dist/2228.web.********************.js`	899 B	0 B
`dotcom-rendering/dist/2339.web.********************.js`	778 B	0 B
`dotcom-rendering/dist/2351.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/2394.web.********************.js`	1.75 kB	0 B
`dotcom-rendering/dist/2467.web.********************.js`	2.08 kB	0 B
`dotcom-rendering/dist/2494.web.********************.js`	774 B	0 B
`dotcom-rendering/dist/2546.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/275.web.********************.js`	697 B	0 B
`dotcom-rendering/dist/3024.web.********************.js`	621 B	0 B
`dotcom-rendering/dist/3146.web.********************.js`	6.53 kB	0 B
`dotcom-rendering/dist/3358.web.********************.js`	637 B	0 B
`dotcom-rendering/dist/356.web.********************.js`	826 B	0 B
`dotcom-rendering/dist/3653.web.********************.js`	12.8 kB	0 B
`dotcom-rendering/dist/3960.web.********************.js`	619 B	0 B
`dotcom-rendering/dist/3968.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/4113.web.********************.js`	757 B	0 B
`dotcom-rendering/dist/4306.web.********************.js`	6.46 kB	0 B
`dotcom-rendering/dist/4591.web.********************.js`	404 B	0 B
`dotcom-rendering/dist/4593.web.********************.js`	1.74 kB	0 B
`dotcom-rendering/dist/4734.web.********************.js`	759 B	0 B
`dotcom-rendering/dist/480.web.********************.js`	524 B	0 B
`dotcom-rendering/dist/4896.web.********************.js`	2.17 kB	0 B
`dotcom-rendering/dist/5021.web.********************.js`	963 B	0 B
`dotcom-rendering/dist/5071.web.********************.js`	941 B	0 B
`dotcom-rendering/dist/5210.web.********************.js`	303 B	0 B
`dotcom-rendering/dist/5211.web.********************.js`	2.92 kB	0 B
`dotcom-rendering/dist/5225.web.********************.js`	6.67 kB	0 B
`dotcom-rendering/dist/5474.web.********************.js`	620 B	0 B
`dotcom-rendering/dist/5688.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/5974.web.********************.js`	742 B	0 B
`dotcom-rendering/dist/6118.web.********************.js`	682 B	0 B
`dotcom-rendering/dist/6126.web.********************.js`	2.23 kB	0 B
`dotcom-rendering/dist/640.web.********************.js`	711 B	0 B
`dotcom-rendering/dist/6437.web.********************.js`	867 B	0 B
`dotcom-rendering/dist/6534.web.********************.js`	575 B	0 B
`dotcom-rendering/dist/6541.web.********************.js`	811 B	0 B
`dotcom-rendering/dist/657.web.********************.js`	2.46 kB	0 B
`dotcom-rendering/dist/6623.web.********************.js`	3.65 kB	0 B
`dotcom-rendering/dist/7133.web.********************.js`	699 B	0 B
`dotcom-rendering/dist/7305.web.********************.js`	886 B	0 B
`dotcom-rendering/dist/7401.web.********************.js`	689 B	0 B
`dotcom-rendering/dist/7569.web.********************.js`	4.91 kB	0 B
`dotcom-rendering/dist/7650.web.********************.js`	23 kB	0 B
`dotcom-rendering/dist/7688.web.********************.js`	814 B	0 B
`dotcom-rendering/dist/786.web.********************.js`	477 B	0 B
`dotcom-rendering/dist/8085.web.********************.js`	2.59 kB	0 B
`dotcom-rendering/dist/8112.web.********************.js`	3.37 kB	0 B
`dotcom-rendering/dist/8165.web.********************.js`	926 B	0 B
`dotcom-rendering/dist/8170.web.********************.js`	490 B	0 B
`dotcom-rendering/dist/818.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/8268.web.********************.js`	5.65 kB	0 B
`dotcom-rendering/dist/8414.web.********************.js`	5.12 kB	0 B
`dotcom-rendering/dist/8439.web.********************.js`	4.97 kB	0 B
`dotcom-rendering/dist/8447.web.********************.js`	963 B	0 B
`dotcom-rendering/dist/8505.web.********************.js`	556 B	0 B
`dotcom-rendering/dist/8555.web.********************.js`	690 B	0 B
`dotcom-rendering/dist/8622.web.********************.js`	858 B	0 B
`dotcom-rendering/dist/8638.web.********************.js`	831 B	0 B
`dotcom-rendering/dist/9422.web.********************.js`	614 B	0 B
`dotcom-rendering/dist/9490.web.********************.js`	825 B	0 B
`dotcom-rendering/dist/9568.web.********************.js`	5.37 kB	0 B
`dotcom-rendering/dist/9597.web.********************.js`	3.25 kB	0 B
`dotcom-rendering/dist/9724.web.********************.js`	5.02 kB	0 B
`dotcom-rendering/dist/AdPortals-importable.web.********************.js`	4.08 kB	0 B
`dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js`	412 B	0 B
`dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js`	7.21 kB	0 B
`dotcom-rendering/dist/AppsEpic-importable.web.********************.js`	3.96 kB	0 B
`dotcom-rendering/dist/AppsFooter-importable.web.********************.js`	3.37 kB	0 B
`dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js`	2.82 kB	0 B
`dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js`	3.27 kB	0 B
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js`	4.86 kB	0 B
`dotcom-rendering/dist/Branding-importable.web.********************.js`	2.2 kB	0 B
`dotcom-rendering/dist/braze-web-sdk-core.web.********************.js`	36.9 kB	0 B
`dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js`	5.5 kB	0 B
`dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js`	6.47 kB	0 B
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js`	5.82 kB	0 B
`dotcom-rendering/dist/CardCommentCount-importable.web.********************.js`	2.69 kB	0 B
`dotcom-rendering/dist/Carousel-importable.web.********************.js`	7.75 kB	0 B
`dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js`	5.6 kB	0 B
`dotcom-rendering/dist/ChartAtom-importable.web.********************.js`	500 B	0 B
`dotcom-rendering/dist/CommentCount-importable.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js`	23.9 kB	0 B
`dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js`	3.3 kB	0 B
`dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js`	3.84 kB	0 B
`dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js`	1.95 kB	0 B
`dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js`	2.5 kB	0 B
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js`	3.31 kB	0 B
`dotcom-rendering/dist/FocusStyles-importable.web.********************.js`	607 B	0 B
`dotcom-rendering/dist/FollowWrapper-importable.web.********************.js`	3.83 kB	0 B
`dotcom-rendering/dist/FooterLabel-importable.web.********************.js`	336 B	0 B
`dotcom-rendering/dist/frameworks.web.********************.js`	20.8 kB	0 B
`dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js`	3.26 kB	0 B
`dotcom-rendering/dist/GetMatchNav-importable.web.********************.js`	12.6 kB	0 B
`dotcom-rendering/dist/GetMatchStats-importable.web.********************.js`	355 B	0 B
`dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js`	2.31 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js`	13.4 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js`	9 kB	0 B
`dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js`	790 B	0 B
`dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js`	10.9 kB	0 B
`dotcom-rendering/dist/index.web.********************.js`	37.8 kB	0 B
`dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js`	3.38 kB	0 B
`dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js`	5.82 kB	0 B
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js`	4.16 kB	0 B
`dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js`	2.78 kB	0 B
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js`	3.51 kB	0 B
`dotcom-rendering/dist/LatestLinks-importable.web.********************.js`	968 B	0 B
`dotcom-rendering/dist/LightboxHash-importable.web.********************.js`	430 B	0 B
`dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js`	4.39 kB	0 B
`dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js`	5.01 kB	0 B
`dotcom-rendering/dist/Liveness-importable.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js`	4.98 kB	0 B
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js`	5.39 kB	0 B
`dotcom-rendering/dist/Metrics-importable.web.********************.js`	2.56 kB	0 B
`dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js`	5.38 kB	0 B
`dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js`	7.7 kB	0 B
`dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js`	3.9 kB	0 B
`dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js`	4.17 kB	0 B
`dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js`	3.65 kB	0 B
`dotcom-rendering/dist/ProfileAtom-importable.web.********************.js`	547 B	0 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js`	810 B	0 B
`dotcom-rendering/dist/PulsingDot-importable.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/QandaAtom-importable.web.********************.js`	542 B	0 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js`	466 B	0 B
`dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js`	3.01 kB	0 B
`dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js`	4.95 kB	0 B
`dotcom-rendering/dist/RecipeMultiplier-importable.web.********************.js`	3.17 kB	0 B
`dotcom-rendering/dist/RelativeTime-importable.web.********************.js`	1.92 kB	0 B
`dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js`	6.34 kB	0 B
`dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js`	4.93 kB	0 B
`dotcom-rendering/dist/SendAMessage-importable.web.********************.js`	4.38 kB	0 B
`dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js`	2.08 kB	0 B
`dotcom-rendering/dist/sentry.web.********************.js`	773 B	0 B
`dotcom-rendering/dist/SetABTests-importable.web.********************.js`	4.53 kB	0 B
`dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js`	514 B	0 B
`dotcom-rendering/dist/shimport.web.********************.js`	2.78 kB	0 B
`dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js`	642 B	0 B
`dotcom-rendering/dist/ShowMore-importable.web.********************.js`	5.59 kB	0 B
`dotcom-rendering/dist/SignInGateMain.web.********************.js`	3.86 kB	0 B
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js`	4.93 kB	0 B
`dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js`	5.76 kB	+98 B (+2%)
`dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js`	6.43 kB	0 B
`dotcom-rendering/dist/Snow-importable.web.********************.js`	3.02 kB	0 B
`dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js`	5.24 kB	0 B
`dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js`	5.74 kB	0 B
`dotcom-rendering/dist/SubNav-importable.web.********************.js`	2.36 kB	0 B
`dotcom-rendering/dist/SupportTheG-importable.web.********************.js`	5.06 kB	0 B
`dotcom-rendering/dist/TableOfContents-importable.web.********************.js`	2.96 kB	0 B
`dotcom-rendering/dist/TimelineAtom-importable.web.********************.js`	1.22 kB	0 B
`dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js`	1.01 kB	0 B
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js`	3.38 kB	0 B
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js`	5.41 kB	0 B
`dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js`	3.23 kB	0 B
`dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js`	5.42 kB	0 B
`dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js`	3.67 kB	0 B

_{compressed-size-action}

refactor(SignInGateSelector): make server safe

5cd154d

mxdvl added this to the Health milestone Oct 31, 2023

mxdvl requested a review from a team as a code owner October 31, 2023 11:11

github-actions Bot added the dotcom-rendering label Oct 31, 2023

mxdvl added the run_chromatic Runs chromatic when label is applied label Oct 31, 2023

ioannakok approved these changes Oct 31, 2023

View reviewed changes

abeddow91 approved these changes Oct 31, 2023

View reviewed changes

mxdvl merged commit e77fdf2 into main Oct 31, 2023

mxdvl deleted the mxdvl/islands-ssr/SupportButton branch October 31, 2023 11:33

mxdvl mentioned this pull request Nov 27, 2023

Make a few more server-safe Island no longer client-side only #9659

Merged

Navigation Menu

Make `SignInGateSelector` Island server safe - #9367

Make `SignInGateSelector` Island server safe#9367
mxdvl merged 1 commit into
mainfrom
mxdvl/islands-ssr/SupportButton

mxdvl commented Oct 31, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mxdvl commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this change?

Why?

Screenshots

Uh oh!

github-actions Bot commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mxdvl commented Oct 31, 2023 •

edited

Loading