Prove remaining Islands are server-safe - #9641
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 700 kB ℹ️ View Unchanged
|
mxdvl
force-pushed
the
mxdvl/islands-ssr/already-safe
branch
2 times, most recently
from
November 23, 2023 20:50
e0fc4ba to
e25246d
Compare
ioannakok
approved these changes
Nov 24, 2023
and make it no longer client-side only
make it no longer client-side only
make it no longer client-side only
mxdvl
force-pushed
the
mxdvl/islands-ssr/already-safe
branch
from
November 24, 2023 10:26
e25246d to
3d69c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Add tests to prove that the following islands are server safe and should no longer be client-side only:
AppEmailSignupMostViewedWrapperShowHideContainerLivenessLiveBlogEpicWhy?
No assumption should be made about where components are run.