Warn on non-SSR friendly code - #9938
Merged
Merged
Conversation
This was referenced Dec 18, 2023
|
Size Change: 0 B Total Size: 730 kB ℹ️ View Unchanged
|
we can make it an error once all 19 instances of non-isomorphic code are addressed
mxdvl
force-pushed
the
mxdvl/ssr-friendly-warn
branch
from
December 18, 2023 18:00
1691b73 to
7050811
Compare
sophie-macmillan
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a new ESLint rule to ensure our code is SSR friendly, but set its level to WARN
We can make it an ERROR once all 19 instances of non-isomorphic code are addressed.
Why?
Prevent regressions from happening after #8991
Enable the work in #9757