Repository navigation
Lift state up in Comments - #9944
Merged
Merged
Conversation
as per the React docs, state should be in a single component. Here, the value of `expanded` is only controlled by Discussion, not Comments, and onExpand is now a required prop https://react.dev/learn/sharing-state-between-components#lifting-state-up-by-example
mxdvl
force-pushed
the
mxdvl/ssr-friendly-comments
branch
from
December 19, 2023 09:59
dffb48b to
8a93dab
Compare
|
Size Change: -40 B (0%) Total Size: 730 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Make
Commentsa controlled component with regard toexpanded.The value of
expandedis only lifted up and controlled byDiscussion, notCommentsitself.onExpandis now a required prop to make this relationship explicit.Why?
As per the React docs, state should be in a single component.
Allows the component to be server-safe, which is a follow-up on