fix(lifecycle): recover owned mux sessions by roodboi · Pull Request #63 · hack-dance/hack

roodboi · 2026-07-09T21:10:02Z

Summary

reconcile deterministic lifecycle mux sessions with token-backed ownership, adopting only healthy owned sessions and safely replacing stale owned sessions
include a deterministic SHA-256 fingerprint of the effective overlay and sorted lifecycle env in freshness, so changed env replaces stale host helpers without persisting names, keys, or values
preserve running Compose services, lifecycle helpers, and ownership state when a down.before guard aborts hack down or hack restart
target detached Zellij sessions through the documented global --session selector for owner metadata, inspection, pane creation, exec, and input
teach doctor to detect and safely repair established ownership-proven orphan sessions while preserving foreign collisions and recent in-flight startups
make the local tmux recovery scenario capability-aware while requiring tmux in the dedicated Docker/tmux CI job

Verification

850 unit tests passed, 5 intentional skips, 0 failed
typecheck, privacy check, canonical Turbo quality checks, changed-file Ultracite, build, generated agent parity, and CLI reference generation passed
full local E2E with tmux mandatory: 9 local scenarios passed; 3 disabled Docker-tier scenarios skipped
lifecycle recovery E2E proves env refresh, failed down/restart guard preservation, ownership safety, signal cleanup, and doctor repair
compiled binary passed the lifecycle session recovery E2E scenario
no-tmux recovery E2E exits 0 with an explicit local skip and exits 1 with zero skips when HACK_E2E_REQUIRE_TMUX=1
live Zellij 0.43.1 detached-session probe wrote and read owner metadata through --session and cleaned up successfully
release tarball extracted and its binary passed version smoke
current-head CI passed secret scan, test/release smoke, runtime images, and non-skippable Docker/tmux E2E
local Docker 29.4.0 responds to info but hangs on container creation; Docker scenarios are proven by current-head CI

Release

Release signal: yes. This is a user-visible lifecycle reliability fix and should produce a patch release through semantic-release. No separate changeset is used by this repository release flow.

roodboi · 2026-07-09T21:12:55Z

CI coverage check: the E2E harness skips Docker scenarios when the hack-dev network is absent. Please make the new docker-e2e job create that network and assert the Docker scenarios actually ran, otherwise the job can pass with all Docker cases skipped.

roodboi · 2026-07-09T21:16:02Z

Addressed in 96fc075: the job now creates the isolated hack-dev network before the run, and HACK_E2E_REQUIRE_DOCKER=1 makes any Docker-tier skip fail the runner. The skip gate also has a local negative-path verification.

roodboi · 2026-07-09T21:17:01Z

Secret scan follow-up: the only finding was a UUID-shaped fake ownership token in a unit test. I replaced it with a constructed low-entropy test value and autosquashed the change into the original commit so the flagged literal is absent from branch history.

roodboi · 2026-07-09T21:17:03Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd66e44fe7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

roodboi · 2026-07-09T21:39:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2148cf5c41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

roodboi · 2026-07-09T21:44:22Z

@codex review

Current head: fd66e44

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2148cf5c41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

roodboi · 2026-07-09T21:54:27Z

@codex review

chatgpt-codex-connector · 2026-07-09T22:00:58Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 91a0c2e0c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

roodboi added 4 commits July 9, 2026 17:16

fix(lifecycle): reconcile owned mux sessions

1600ced

fix(doctor): reap owned orphan lifecycle sessions

d008a98

ci: run Docker end-to-end scenarios

f849649

ci: require Docker scenarios to execute

fd66e44

roodboi force-pushed the codex/lifecycle-session-recovery branch from 96fc075 to fd66e44 Compare July 9, 2026 21:16

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread src/commands/project.ts

Comment thread tests/e2e/run.ts

fix(lifecycle): refresh sessions for env changes

2148cf5

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread src/commands/project.ts Outdated

Comment thread src/mux/zellij-backend.ts Outdated

roodboi added 2 commits July 9, 2026 17:50

fix(lifecycle): preserve sessions when shutdown guards fail

8066934

fix(zellij): target detached sessions explicitly

91a0c2e

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread src/mux/zellij-backend.ts Outdated

roodboi merged commit c1da123 into main Jul 9, 2026
5 checks passed

roodboi deleted the codex/lifecycle-session-recovery branch July 9, 2026 22:02

Uh oh!

Conversation

roodboi commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Release

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

roodboi commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

roodboi commented Jul 9, 2026 •

edited

Loading