fix(runtime): recognize Compose completion gates#65
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d61b36d733
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95990d182c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a1c107dad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad10c6b038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
## Summary - inject versioned, non-secret runtime host metadata into every Compose service - expose branch-qualified public route maps plus current-service convenience fields - make `up`, `restart`, targeted restart, `run`, and `exec` inspection consume consistent generated Compose overrides - extract and directly test branch-host rewriting - document Compose-DNS vs public-URL usage and bump agent-integration freshness ## Runtime contract Containers receive `HACK_RUNTIME_METADATA`, `HACK_DEV_URL`, `HACK_ALIAS_URL`, `HACK_SERVICE_NAME`, `HACK_SERVICE_URL`, and `HACK_SERVICE_URLS`. The versioned JSON document includes all routable services, avoiding lossy service-name-to-env-key conversion. Explicit project env values retain precedence for backward compatibility. ## Verification - `bun test` — 897 pass, 5 skip, 0 fail - focused metadata/branch/run/exec/agent tests — 27 pass, 0 fail - `bun run check` - `bun run typecheck` - `bun run build` - Docker E2E `worktree-parallel-up` — primary and branch containers expose distinct URLs; metadata survives restart ## Release decision This is a user-facing runtime capability and should produce a feature/minor release signal. The Conventional Commit title intentionally uses `feat(runtime)`. ## Landing order PR #65 should land first; then this branch should be updated from `main` before merge so its `project.ts` changes include the completion-gate fixes.
Summary
depends_on.condition: service_completed_successfullyRoot cause
Hack v3.3.6 only accepted exited-zero services when they were dependency installers or carried
hack.service.one-shot=true. Valid Compose completion gates such as Event Agentdb-opswere therefore reported asE_STARTUP_INCOMPLETEafter the stack had started successfully.Verification
bun test— 893 pass, 5 skip, 0 failbun run checkbun run typecheckbun run build