Skip to content

fix: dispatch releases explicitly after tagging #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roodboi merged 1 commit into from
Mar 26, 2026
Merged

fix: dispatch releases explicitly after tagging #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
tags:
- "v*"
workflow_dispatch:
inputs:
tag:
description: Tag to release, for example v1.2.3
required: false

permissions:
contents: write
Expand All @@ -16,6 +20,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.inputs.tag || github.ref }}
- uses: actions/setup-go@v5
with:
go-version-file: go.mod
Expand Down
27 changes: 21 additions & 6 deletions .github/workflows/tag-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ on:
required: false

permissions:
actions: write
contents: write
issues: write
pull-requests: write
Expand Down Expand Up @@ -51,23 +52,37 @@ jobs:
echo "version=$version" >> "$GITHUB_OUTPUT"

- name: Create tag if missing
id: create_tag
env:
PUSH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN || github.token }}
TARGET_SHA: ${{ github.event.inputs.sha || github.event.pull_request.merge_commit_sha || github.sha }}
run: |
tag="v${{ steps.version.outputs.version }}"
created="false"

git fetch --tags origin
if git rev-parse "$tag" >/dev/null 2>&1; then
echo "tag $tag already exists"
exit 0
else
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git remote set-url origin "https://x-access-token:${PUSH_TOKEN}@github.com/${{ github.repository }}.git"
git tag "$tag" "$TARGET_SHA"
git push origin "$tag"
created="true"
fi

git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git remote set-url origin "https://x-access-token:${PUSH_TOKEN}@github.com/${{ github.repository }}.git"
git tag "$tag" "$TARGET_SHA"
git push origin "$tag"
echo "tag=$tag" >> "$GITHUB_OUTPUT"
echo "created=$created" >> "$GITHUB_OUTPUT"

- name: Dispatch release workflow
if: steps.create_tag.outputs.created == 'true'
env:
GH_TOKEN: ${{ github.token }}
run: |
gh workflow run release.yml \
--ref main \
-f tag="${{ steps.create_tag.outputs.tag }}"
Comment on lines +83 to +85

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate manual dispatch to avoid duplicate release runs

This new gh workflow run release.yml call can trigger a second release for the same tag when RELEASE_PLEASE_TOKEN is configured, because Create tag if missing pushes with that token and release.yml still listens on push.tags. GitHub documents that events from GITHUB_TOKEN are suppressed except workflow_dispatch/repository_dispatch, but pushes made with a PAT do trigger downstream workflows, so this change can run GoReleaser twice for one version (typically causing one run to fail on existing release/formula artifacts). Consider dispatching only when the push used github.token, or removing/tag-scoping the push trigger.

Useful? React with 👍 / 👎.


- name: Mark release PR as tagged
if: github.event_name == 'pull_request_target' || github.event.inputs.pr_number != ''
Expand Down
4 changes: 2 additions & 2 deletions docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This repo uses conventional commits on `main` plus `release-please` and
parseable release commits.
- `release-please` watches `main`, opens a release PR, updates `CHANGELOG.md`, and bumps the version manifest.
- Merging the release PR triggers `tag-release`, which creates the Git tag from the merged release commit.
- Tag pushes trigger `goreleaser`, which builds artifacts, creates the GitHub Release, and updates `hack-dance/homebrew-tap`.
- `tag-release` then dispatches the `release` workflow for that tag so `goreleaser` builds artifacts, creates the GitHub Release, and updates `hack-dance/homebrew-tap`.

## Required secrets

Expand All @@ -27,7 +27,7 @@ This repo uses conventional commits on `main` plus `release-please` and
3. Review the generated version and changelog.
4. Merge the release PR.
5. Verify `tag-release` pushed the expected `vX.Y.Z` tag.
6. Verify the `release` workflow published artifacts and updated the Homebrew tap.
6. Verify the dispatched `release` workflow published artifacts and updated the Homebrew tap.

## Local dry run

Expand Down
Loading