Shambhavi's MIDI hackpad - #181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shim-sham
marked this pull request as draft
October 21, 2024 20:37
shim-sham
marked this pull request as ready for review
October 21, 2024 20:39
Collaborator
|
Hey! Do you have a top for this case? I see screw holes, but no screw holes on the PCB. Also, you can request screws in the BOM! |
Contributor
Author
|
hi! i don't have a top for the case, the pcb will just slot in |
Merged
souptik-samanta
suggested changes
Oct 24, 2024
Contributor
There was a problem hiding this comment.
Need to add files in prodction if qmk : the .uf2 files
if kmk then boot.py and code/main.py
also could you add you pcb in the ..CAD/case.step file ?
something like this with add parts at their place
without that everything looks great do that and ping me in slack @souptik-samanta
I will surely approve !!
shim-sham
marked this pull request as draft
October 24, 2024 18:08
shim-sham
marked this pull request as ready for review
October 24, 2024 18:10
souptik-samanta
approved these changes
Oct 24, 2024
souptik-samanta
approved these changes
Oct 24, 2024
Contributor
Author
|
done... hopefully |
Contributor
|
I approve #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.