about "strict sni".

[NewBugger]

in the patch , it contains this:

diff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c
--- a/src/event/ngx_event_openssl.c    2018-10-02 15:13:36.414143028 +0000
+++ b/src/event/ngx_event_openssl.c    2018-10-04 13:58:28.756873433 +0000
@@ -1456,6 +1456,13 @@ ngx_ssl_handshake(ngx_connection_t *c)

     c->read->error = 1;

+
+    if (sslerr == SSL_ERROR_SSL) {
+        ERR_peek_error();
+        ERR_clear_error();
+        return NGX_ERROR;
+    }
+
     ngx_ssl_connection_error(c, sslerr, err, "SSL_do_handshake() failed");

return NGX_ERROR;

but in this commit :

Not compatible with ssl_early_data.

i use BoringSSL and ssl_early_data on; directive.

[hakasenyang]

An error log appears in nginx/error.log.

If ssl_early_data is turned on in a browser that supports TLS 1.3, a related error will occur.

[NewBugger]

soga. thanks.

[hakasenyang]

@NewBugger Fixed early data related errors!

Using this patch file.
https://github.com/hakasenyang/openssl-patch/blob/master/nginx_1.15.4_strict-sni.patch

[NewBugger]

ok, i'll try it.

[NewBugger]

and i met a issue , i'll try this patch to check whether it can solve this.

[CarterLi]

I got ERR_SSL_UNRECOGNIZED_NAME_ALERT when using nginx_1.15.4_strict-sni.patch with nginx 1.15.5

I got no such errors with the old nginx_strict-sni.patch

[hakasenyang]

@CarterLi If you want to terminate a full connection, this patch is not correct.
It is normal for the error message to appear.

In OpenSSL Source : ssl/statem/extensions.c

    case SSL_TLSEXT_ERR_ALERT_FATAL:
        SSLfatal(s, altmp, SSL_F_FINAL_SERVER_NAME, SSL_R_CALLBACK_FAILED);
        return 0;

SSLfatal called SSL_F_FINAL_SERVER_NAME.

static int final_server_name(SSL *s, unsigned int context, int sent)
{
    int ret = SSL_TLSEXT_ERR_NOACK;
    int altmp = SSL_AD_UNRECOGNIZED_NAME;
    int was_ticket = (SSL_get_options(s) & SSL_OP_NO_TICKET) == 0;

If you want a complete connection shutdown, use the old version of the patch.
Here is the source.

nginx

Same source.

diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c
--- a/src/http/ngx_http_request.c	2018-09-15 10:02:36.520076032 +0000
+++ b/src/http/ngx_http_request.c	2018-09-15 10:26:32.826874950 +0000
@@ -882,7 +882,7 @@
     servername = SSL_get_servername(ssl_conn, TLSEXT_NAMETYPE_host_name);
 
     if (servername == NULL) {
-        return SSL_TLSEXT_ERR_NOACK;
+        return SSL_TLSEXT_ERR_ALERT_FATAL;
     }
 
     c = ngx_ssl_get_connection(ssl_conn);
@@ -897,7 +897,7 @@
     host.len = ngx_strlen(servername);
 
     if (host.len == 0) {
-        return SSL_TLSEXT_ERR_NOACK;
+        return SSL_TLSEXT_ERR_ALERT_FATAL;
     }
 

     host.data = (u_char *) servername;
@@ -912,7 +912,7 @@
                                      NULL, &cscf)
         != NGX_OK)
     {
-        return SSL_TLSEXT_ERR_NOACK;
+        return SSL_TLSEXT_ERR_ALERT_FATAL;
     }
 
     hc->ssl_servername = ngx_palloc(c->pool, sizeof(ngx_str_t));

OpenSSL

diff --git a/ssl/statem/extensions.c b/ssl/statem/extensions.c
index 8422161dc1..75de3dd263 100644
--- a/ssl/statem/extensions.c
+++ b/ssl/statem/extensions.c
@@ -998,7 +998,10 @@ static int final_server_name(SSL *s, unsigned int context, int sent)

     switch (ret) {
     case SSL_TLSEXT_ERR_ALERT_FATAL:
-        SSLfatal(s, altmp, SSL_F_FINAL_SERVER_NAME, SSL_R_CALLBACK_FAILED);
+        //SSLfatal(s, altmp, SSL_F_FINAL_SERVER_NAME, SSL_R_CALLBACK_FAILED);
+        s->statem.in_init = 1;
+        s->statem.state = MSG_FLOW_ERROR;
+        ssl3_send_alert(s, SSL3_AL_FATAL, SSL_F_FINAL_RENEGOTIATE);
         return 0;

     case SSL_TLSEXT_ERR_ALERT_WARNING:

[NewBugger]

@hakasenyang
i want a complete connection shutdown, so whether i not need this:

    if (sslerr == SSL_ERROR_SSL) {
        ERR_peek_error();
        ERR_clear_error();
        return NGX_ERROR;
    }

but the old version of patch has a problem at early data...

[NewBugger]

additionally, i made a change in this:

    if (sslerr == SSL_ERROR_SSL) {
        ERR_peek_error();
        ERR_clear_error();
        return NGX_ERROR;
    }

change it to :

    if (sslerr == SSL_ERROR_SSL) {
        ngx_ssl_clear_error(c->log);
        return NGX_ERROR;
    }

[hakasenyang]

@NewBugger I will test and change the source. :)
Thank you so much.

Does the patch I uploaded have the same error(early data)?

[NewBugger]

@hakasenyang
maybe due to i use BoringSSL rather than Openssl,
i use ssl_early_data on and there is no error log like early data.