fix(watcher): release watch descriptor on subdirectory deletion - #54
Merged
Merged
Conversation
Deleting a watched subdirectory left its OS-level watch descriptor registered until the process exited. On Linux this leaks inotify fds toward the max_user_watches limit; on macOS it leaks kqueue entries. A removed-then-recreated subdirectory would also silently stop triggering onChange for files written inside it. On fsnotify.Remove, check whether the path is present in WatchList() (used as the single source of truth because os.Stat fails on an already-deleted path) and call fw.Remove to release the descriptor. Re-creation falls through to the existing Create branch unchanged. Fixes #51
harrydayexe
added a commit
that referenced
this pull request
Jun 8, 2026
The subdirectory-deletion handler merged in from #54 still referenced the old local `logger` variable that was removed when config.Logger was embedded on Watcher. Replace both call sites with w.Logger.Logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a watched subdirectory left its OS-level watch descriptor registered until the process exited. On Linux this leaks inotify fds toward the max_user_watches limit; on macOS it leaks kqueue entries. A removed-then-recreated subdirectory would also silently stop triggering onChange for files written inside it.
On fsnotify.Remove, check whether the path is present in WatchList() (used as the single source of truth because os.Stat fails on an already-deleted path) and call fw.Remove to release the descriptor. Re-creation falls through to the existing Create branch unchanged.
Fixes #51
Changelog (#54)
🐛 Bug Fixes