fix(chart): use boolean values instead of string literals for booleans - #744
Merged
Conversation
leninmehedy
changed the base branch from
main
to
431-consolidate-sidecar-templates
February 8, 2024 00:09
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=========================================
Coverage 67.51% 67.51%
Complexity 339 339
=========================================
Files 64 64
Lines 1336 1336
Branches 157 157
=========================================
Hits 902 902
Misses 371 371
Partials 63 63 |
jeromy-cannon
approved these changes
Feb 8, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
jeromy-cannon
force-pushed
the
479-fix-chart-boolean-values
branch
from
February 8, 2024 09:49
92f5e5b to
6b00cc4
Compare
|
swirlds-automation
added a commit
that referenced
this pull request
Feb 9, 2024
## [0.21.0](v0.20.0...v0.21.0) (2024-02-09) ### Features * **cli:** allow user to overriding properties files ([#738](#738)) ([72982a5](72982a5)) ### Bug Fixes * **chart:** consolidate sidecar templates into the main network deployment template ([#743](#743)) ([b2872a1](b2872a1)) * **chart:** disable backup-uploader ([#746](#746)) ([d2b7010](d2b7010)) * **chart:** use boolean values instead of string literals for booleans ([#744](#744)) ([d6567a9](d6567a9)) * **cli:** assign node account ID correctly base on start account ID ([#749](#749)) ([6149153](6149153)) * **cli:** solo init should reset cached config ([#737](#737)) ([911d25b](911d25b)) * fullstack cluster setup is not uninstalling correctly ([#742](#742)) ([56402e0](56402e0))
Contributor
|
🎉 This PR is included in version 0.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues