SRE-927: Migrate same-repo action references to the $/ syntax - #156
TimDiekmann merged 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Preflight layout changes: Lint-driven fixes in Reviewed by Cursor Bugbot for commit b302f11. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
This PR migrates same-repo GitHub Action references to the $/ self-repository syntax and consolidates/updates the Preflight workflows to include a centralized actionlint-based lint job.
Changes:
- Update workflow
uses:references from./.github/actions/...to$/...and address actionlint/shellcheck findings (quoting$GITHUB_OUTPUTredirects). - Consolidate PR preflights into
.github/workflows/preflight.ymland add a centralized actionlint lint job. - Move
pull_request_targetpreflights into.github/workflows/preflight-target.ymlwhile keeping existing dependency/title checks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/rust.yml | Switches local composite action references to $/ and fixes shellcheck/actionlint-flagged output redirections. |
| .github/workflows/preflight.yml | Consolidates PR preflight triggers and adds centralized actionlint lint job with restricted default permissions. |
| .github/workflows/preflight-todo-comments.yml | Removes the now-redundant standalone todo-comments preflight workflow. |
| .github/workflows/preflight-target.yml | Introduces a dedicated pull_request_target preflight workflow for dependency and PR-title checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Purpose
Migrates same-repo action references to the
$/self-repository syntax and wires up the centralized actionlint preflight (hashintel/.github#100–#102), which lints all workflow files on every PR.Related links
What does this change?
uses: ./.github/actions/…→$/.github/actions/…in workflows and composite actions$GITHUB_OUTPUT/$GITHUB_ENVredirects, and backticks in echoed help text replaced with double quotes (shellcheck reads them as command substitution)pull_requestpreflights are consolidated into onepreflight.yml: Todo comments plus the new Lint job calling the centralizedpreflight-actionlint.yml(check name:Preflight / Lint / Actions). Thepull_request_targetfile moves topreflight-target.yml; check names stay unchanged.How to test this?
$/Preflight / Lint / Actionscheck lints this repo's workflows with only the three syntax-gap ignores ($/,concurrency.queue; SRE-941)