Skip to content

SRE-927: Migrate same-repo action references to the $/ syntax - #156

Merged
TimDiekmann merged 4 commits into
mainfrom
t/sre-927-migrate-same-repository-action-and-workflow-references-to
Aug 11, 2026
Merged

TimDiekmann merged 4 commits into
mainfrom
t/sre-927-migrate-same-repository-action-and-workflow-references-to

Conversation

@TimDiekmann

@TimDiekmann TimDiekmann commented Aug 11, 2026 •

Copy link
Copy Markdown
Member

Purpose

Migrates same-repo action references to the $/ self-repository syntax and wires up the centralized actionlint preflight (hashintel/.github#100–#102), which lints all workflow files on every PR.

Related links

What does this change?

  • uses: ./.github/actions/… → $/.github/actions/… in workflows and composite actions
  • Fixes the actionlint/shellcheck findings the new check surfaces: quoted $GITHUB_OUTPUT/$GITHUB_ENV redirects, and backticks in echoed help text replaced with double quotes (shellcheck reads them as command substitution)
  • The pull_request preflights are consolidated into one preflight.yml: Todo comments plus the new Lint job calling the centralized preflight-actionlint.yml (check name: Preflight / Lint / Actions). The pull_request_target file moves to preflight-target.yml; check names stay unchanged.

How to test this?

  • Every job on this PR resolves its composite actions via $/
  • The Preflight / Lint / Actions check lints this repo's workflows with only the three syntax-gap ignores ($/, concurrency.queue; SRE-941)

@TimDiekmann TimDiekmann self-assigned this Aug 11, 2026
@vercel

vercel Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
petrinaut-hazel Ready Ready Preview Aug 11, 2026 11:09am

@TimDiekmann
TimDiekmann requested a review from a team August 11, 2026 10:53
@TimDiekmann
TimDiekmann marked this pull request as ready for review August 11, 2026 10:53
Copilot AI lite review requested due to automatic review settings August 11, 2026 10:53
@cursor

cursor Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to GitHub Actions wiring and shell quoting; no application runtime or security-sensitive logic is modified.

Overview
CI workflow maintenance for SRE-927: same-repository composite actions now reference $/… instead of ./… (e.g. in rust.yml), and reusable preflight workflows are pinned to a newer hashintel/.github SHA.

Preflight layout changes: pull_request checks live in preflight.yml (todo-comments + new Lint job via centralized preflight-actionlint.yml). pull_request_target jobs (dependencies, PR title) move to preflight-target.yml. The standalone preflight-todo-comments.yml workflow is removed.

Lint-driven fixes in rust.yml: quote $GITHUB_OUTPUT paths/redirects and adjust the setup script env export pattern so actionlint/shellcheck pass.

Reviewed by Cursor Bugbot for commit b302f11. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates same-repo GitHub Action references to the $/ self-repository syntax and consolidates/updates the Preflight workflows to include a centralized actionlint-based lint job.

Changes:

  • Update workflow uses: references from ./.github/actions/... to $/... and address actionlint/shellcheck findings (quoting $GITHUB_OUTPUT redirects).
  • Consolidate PR preflights into .github/workflows/preflight.yml and add a centralized actionlint lint job.
  • Move pull_request_target preflights into .github/workflows/preflight-target.yml while keeping existing dependency/title checks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/rust.yml Switches local composite action references to $/ and fixes shellcheck/actionlint-flagged output redirections.
.github/workflows/preflight.yml Consolidates PR preflight triggers and adds centralized actionlint lint job with restricted default permissions.
.github/workflows/preflight-todo-comments.yml Removes the now-redundant standalone todo-comments preflight workflow.
.github/workflows/preflight-target.yml Introduces a dedicated pull_request_target preflight workflow for dependency and PR-title checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/preflight-target.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@TimDiekmann
TimDiekmann added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit bdb468c Aug 11, 2026
18 of 22 checks passed
@TimDiekmann
TimDiekmann deleted the t/sre-927-migrate-same-repository-action-and-workflow-references-to branch August 11, 2026 11:40

This branch had an error being deployed

1 failed and 1 active deployments
Preview – petrinaut-hazel — b302f11d Deployed Aug 11, 2026 by vercel[bot]
Preview – hcore — b302f11d Deployed Aug 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants