Skip to content

fix(package): Update stale pause point guidance in tool skills#1688

Merged
hatayama merged 1 commit into
v3-betafrom
fix/stale-pause-point-skill-guidance
Jul 11, 2026
Merged

fix(package): Update stale pause point guidance in tool skills#1688
hatayama merged 1 commit into
v3-betafrom
fix/stale-pause-point-skill-guidance

Conversation

@hatayama

@hatayama hatayama commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

Changes

  • execute-dynamic-code: the "add a Debug.Log before UloopPausePoint.Pause() and read it back via get-logs" workflow for method locals is replaced with enabling a source pause point and reading CapturedVariables from the hit response (no code edit or recompile)
  • simulate-keyboard / simulate-mouse-input: PausePointId / PausePointHitCount output docs now describe the derived <file>:<line> id returned by enable-pause-point instead of UloopPausePoint.Pause()
  • simulate-mouse-ui: documents the InterruptedByPausePoint / PausePointId / PausePointHitCount / PausePointHits response fields added in fix(package): Stop tools from hanging when a pause point fires mid-command #1685 (keyboard and mouse-input already documented them) and the Message dispatch-state contract (whether the pointer event fired before the pause)
  • All three input skills: "place markers ..., not immediately after simulate-*" is replaced with the Line Placement guidance that mid-command pauses are safe and return promptly; "remove temporary pause-point/log instrumentation" becomes "clear pause points"
  • .claude/ and .agents/ copies regenerated via uloop skills install --claude --agents, byte-identical to sources

Test plan

  • Regeneration: 4 updated / 15 skipped per location; cmp confirms all copies byte-identical to sources
  • grep confirms zero UloopPausePoint mentions remain across all skill sources
  • Body-only markdown edits — no C# or skill frontmatter changes (compile and skill layout tests unaffected)

Review in cubic

The source pause point rework (enable-pause-point --file/--line with
CapturedVariables) left four tool skills describing the retired
workflow:

- execute-dynamic-code told agents to add a Debug.Log before
  UloopPausePoint.Pause() and read it back via get-logs. CapturedVariables
  replaced that flow, and skills must not surface the emergency-only
  handwritten-marker API.
- simulate-keyboard and simulate-mouse-input documented PausePointId as
  coming from UloopPausePoint.Pause() instead of the derived
  <file>:<line> id returned by enable-pause-point.
- simulate-mouse-ui never documented the InterruptedByPausePoint,
  PausePointId, PausePointHitCount, and PausePointHits response fields
  or the Message dispatch-state contract added with the mid-command
  interruption fix.
- The shared "place markers ... not immediately after" wording
  contradicted the pause point skill's Line Placement guidance that
  mid-command pauses are safe and return promptly.

Generated .claude/.agents copies are regenerated and byte-identical to
the sources.
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6b918547-0964-4cf2-9251-2377c342321f

📥 Commits

Reviewing files that changed from the base of the PR and between 998ce19 and ecdc2c0.

📒 Files selected for processing (12)
  • .agents/skills/uloop-execute-dynamic-code/SKILL.md
  • .agents/skills/uloop-simulate-keyboard/SKILL.md
  • .agents/skills/uloop-simulate-mouse-input/SKILL.md
  • .agents/skills/uloop-simulate-mouse-ui/SKILL.md
  • .claude/skills/uloop-execute-dynamic-code/SKILL.md
  • .claude/skills/uloop-simulate-keyboard/SKILL.md
  • .claude/skills/uloop-simulate-mouse-input/SKILL.md
  • .claude/skills/uloop-simulate-mouse-ui/SKILL.md
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.md
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.md
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/Skill/SKILL.md
  • Packages/src/Editor/FirstPartyTools/SimulateMouseUi/Skill/SKILL.md

📝 Walkthrough

Walkthrough

Documentation for dynamic-code inspection and keyboard/mouse simulation now reflects source pause points, CapturedVariables, mid-command interruption responses, pause-point identifiers, hit metadata, and cleanup procedures across mirrored skill files.

Changes

Pause-point guidance

Layer / File(s) Summary
Captured variable inspection
.agents/skills/uloop-execute-dynamic-code/SKILL.md, .claude/skills/uloop-execute-dynamic-code/SKILL.md, Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.md
Dynamic-code guidance now directs inspection through source pause points and CapturedVariables instead of temporary logging and get-logs.
Keyboard and mouse input pause contracts
.agents/skills/uloop-simulate-{keyboard,mouse-input}/SKILL.md, .claude/skills/uloop-simulate-{keyboard,mouse-input}/SKILL.md, Packages/src/Editor/FirstPartyTools/Simulate{Keyboard,MouseInput}/Skill/SKILL.md
Input simulation guidance documents safe mid-command pauses, settled-state placement, pause-point cleanup, and derived <file>:<line> identifiers.
Mouse UI pause diagnostics
.agents/skills/uloop-simulate-mouse-ui/SKILL.md, .claude/skills/uloop-simulate-mouse-ui/SKILL.md, Packages/src/Editor/FirstPartyTools/SimulateMouseUi/Skill/SKILL.md
Mouse UI guidance documents interruption messages, event-dispatch interpretation, cleanup, and pause-point diagnostic output fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: refreshing outdated pause-point guidance across tool skills.
Description check ✅ Passed The description directly matches the changeset and explains the updated pause-point workflow and regenerated skill copies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stale-pause-point-skill-guidance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit ec3f545 into v3-beta Jul 11, 2026
6 checks passed
@hatayama
hatayama deleted the fix/stale-pause-point-skill-guidance branch July 11, 2026 11:43
@github-actions github-actions Bot mentioned this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant