Skip to content

fix: Simplify and deduplicate agent skill definitions and code references#1367

Merged
hatayama merged 9 commits into
v3-betafrom
fix/improve-skills
Jun 18, 2026
Merged

fix: Simplify and deduplicate agent skill definitions and code references#1367
hatayama merged 9 commits into
v3-betafrom
fix/improve-skills

Conversation

@hatayama

@hatayama hatayama commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove verbosity and cross-file duplication from uloop skill SKILL.md files and execute-dynamic-code reference examples
  • Net reduction of 228 lines across 21 source files in the package

User Impact

  • Agent skill files are loaded into context on every tool invocation. Shorter, less redundant files reduce token consumption and improve signal-to-noise for AI agents reading them.
  • No runtime or CLI behavior changes — these are agent-facing documentation files only.

Changes

Skill files (15 SKILL.md files)

  • Consolidate Pause Point Inspection sections in simulate-keyboard, simulate-mouse-input, and simulate-mouse-ui into a single reference to uloop-wait-for-pause-point
  • Merge duplicate Input System prerequisite lines across 4 input simulation tools
  • Remove defensive non-existent field enumeration patterns from output sections
  • Shorten verbose explanations (run-tests NoTestsFound, get-logs intro, control-play-mode Notes, focus-window Notes, launch Output)
  • Remove implementation-detail Notes from hello-world
  • Deduplicate When To Use / Marker Placement overlap in wait-for-pause-point
  • Move pause-point guidance out of get-logs (already covered by wait-for-pause-point)

Reference examples (6 files)

  • asset-operations: merge 3 FindAssets variants into one with commented alternatives
  • cleanup-operations: merge single-object and scene-wide missing reference scans; remove Find Empty GameObjects (covered by Remove Empty Leaf)
  • selection-operations: merge 3 SelectionMode variants and 2 asset selection variants
  • playmode-ui-controls: merge slider and toggle section pairs
  • scriptableobject: merge single-property and multi-property SerializedObject examples
  • scene-operations: remove Find GameObjects by Tag (playmode-inspection has a more detailed version)

Verification

  • Reviewed all 21 changed files for content preservation
  • Confirmed generated copies (.claude/, .agents/, .codex/) are unchanged vs origin/v3-beta

Review in cubic

hatayama added 7 commits June 18, 2026 15:36
- Consolidate Pause Point Inspection sections in simulate-keyboard,
  simulate-mouse-input, and simulate-mouse-ui into references to
  uloop-wait-for-pause-point instead of repeating the full guidance
- Merge duplicate Input System prerequisite lines across 4 files
- Remove defensive "non-existent field enumeration" patterns from
  record-input, replay-input, simulate-mouse-input, simulate-mouse-ui
- Shorten verbose explanations: run-tests NoTestsFound, get-logs
  pause-point intro, control-play-mode Notes, focus-window Notes
- Remove implementation-detail Notes from hello-world
- Deduplicate When To Use / Marker Placement in wait-for-pause-point
- Clean up launch Output section (separate JSON fields from prose)
- Remove redundant compare-table repetition in simulate-mouse-input
The pause-point + get-logs workflow is already documented in
uloop-wait-for-pause-point, including the --search-text fallback.
Propagate the .claude/skills changes to the source definitions in
Packages/src/Editor and to the .agents and .codex generated copies.
These are generated copies; revert to let the normal regeneration
workflow handle the sync.
These are generated copies; only the package source definitions
should carry the changes.
Four files still diverged because local v3-beta tag was stale.
- asset-operations: merge 3 FindAssets variants into one with
  commented filter alternatives; clarify Rename (no Undo) heading
- cleanup-operations: merge single-object and scene-wide missing
  reference scans into one; remove Find Empty GameObjects (covered
  by Remove Empty Leaf with a comment for list-only usage)
- selection-operations: merge 3 SelectionMode variants into one;
  merge asset selection variants with usage note
- playmode-ui-controls: merge 2 slider sections (bounds check
  subsumes plain set); merge 2 toggle sections with flip/set note
- scriptableobject: merge single-property and multi-property
  SerializedObject examples into one with type setter guidance
- scene-operations: remove Find GameObjects by Tag (playmode-
  inspection has a more detailed version)
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Documentation-only refresh across 20 SKILL.md and reference markdown files for Unity CLI loop tools. Changes trim or rewrite Output field lists, Notes bullets, and Prerequisites wording, and consolidate execute-dynamic-code reference examples (asset operations, cleanup, PlayMode UI controls, scene operations, scriptable objects, selection operations).

Changes

SKILL.md and reference doc updates

Layer / File(s) Summary
CliOnlyTools: FocusWindow, Launch, PausePoint docs
Packages/src/Editor/CliOnlyTools~/FocusWindow/Skill/SKILL.md, Packages/src/Editor/CliOnlyTools~/Launch/Skill/SKILL.md, Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/SKILL.md
FocusWindow removes the Parameters section and trims Notes bullets. Launch rewrites the Output section to enumerate all returned JSON fields (success, ready, serverReady, projectIpcReady, alreadyRunning, launched, restarted, quit, previousProcessId, currentProcessId, projectRoot, message) and shortens Notes to three key behaviors (existing-process focus/verification, IPC-probing fallback when process scanning is blocked, and waiting for startup/CLI connectivity). PausePoint replaces "good pause points" guidance with a lightweight-breakpoint framing.
Core FirstPartyTools Output/Notes/Prerequisites updates
Packages/src/Editor/FirstPartyTools/ClearConsole/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/ControlPlayMode/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/FindGameObjects/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/GetLogs/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/RunTests/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/Screenshot/Skill/SKILL.md
ClearConsole clarifies message on failure and drops errorMessage. ControlPlayMode replaces Notes with Stop/Step edge-case bullets. FindGameObjects clarifies totalFound as post---max-results. GetLogs removes pause-point Debug.Log guidance and updates Output to state that request input filters (logType, maxCount, searchText, includeStackTrace) are echoed back in the response. RunTests tightens compile precondition and shortens NoTestsFound explanation. Screenshot removes the combined-options example.
Input simulation and recording tools docs
Packages/src/Editor/FirstPartyTools/RecordInput/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/ReplayInput/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/SimulateMouseInput/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/SimulateMouseUi/Skill/SKILL.md
RecordInput and ReplayInput reword Prerequisites to explicitly state New Input System only; ReplayInput removes the eight-fields claim. SimulateKeyboard shortens Pause Point Inspection to direct use of uloop-wait-for-pause-point and tightens Prerequisites. SimulateMouseInput revises Pause Point Inspection, simplifies the comparison table by assuming New Input System for all rows, rewrites Prerequisites, and replaces the Output note with a screenshot follow-up. SimulateMouseUi removes the Drag --button Left constraint, shortens Pause Point Inspection, and adds a screenshot verification instruction.
ExecuteDynamicCode SKILL.md and reference examples
Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.md, Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/references/asset-operations.md, .../cleanup-operations.md, .../playmode-ui-controls.md, .../scene-operations.md, .../scriptableobject.md, .../selection-operations.md
SKILL.md updates Workflow step 4 to "Report the execution result" and consolidates the error/errorMessage Output bullet. Reference files: asset-operations.md consolidates Find Assets to a single type-based example; cleanup-operations.md rewrites Scan for Missing References with scanSelectionOnly switch and removes Find Empty GameObjects; playmode-ui-controls.md updates Slider and Toggle examples to enumerate by name with fallback error messages; scene-operations.md removes Find GameObjects by Tag; scriptableobject.md shortens the SerializedObject snippet; selection-operations.md generalizes selection-mode and asset-selection documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • hatayama/unity-cli-loop#1301: Directly overlaps with this PR's uloop launch Output section rewrite — both enumerate the same JSON response fields (ready, serverReady, projectIpcReady, alreadyRunning, launched, restarted, etc.).
  • hatayama/unity-cli-loop#1302: Both PRs update pause-point and frame-debugging documentation across multiple tools, including PausePoint/SKILL.md, GetLogs, SimulateKeyboard, SimulateMouseInput, and SimulateMouseUi.
  • hatayama/unity-cli-loop#1345: Both PRs update pause-point documentation and E2E workflow messaging, with this PR revising PausePoint/SKILL.md location guidance while #1345 refines uloop-wait-for-pause-point skill description.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The PR description comprehensively covers the changes, including the rationale (reducing token consumption for AI agents), specific modifications to 15 skill files and 6 reference examples, and notes that these are documentation-only changes with no runtime impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The PR title accurately summarizes the main objective: simplifying and deduplicating agent skill definitions and code references across 21 files with a net 228-line reduction.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/improve-skills

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 21 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread Packages/src/Editor/FirstPartyTools/RunTests/Skill/SKILL.md Outdated
hatayama added 2 commits June 18, 2026 17:19
"edited" alone was too narrow — creating, deleting, renaming, or
moving C#/test/asmdef files also requires recompilation.
Address codex-review findings by making dynamic-code examples deterministic, non-destructive, and aligned with actual launch output.
@hatayama hatayama changed the title chore: Simplify and deduplicate agent skill definitions and code references fix: Simplify and deduplicate agent skill definitions and code references Jun 18, 2026
@hatayama
hatayama merged commit 83cfc25 into v3-beta Jun 18, 2026
6 checks passed
@hatayama
hatayama deleted the fix/improve-skills branch June 18, 2026 10:19
@github-actions github-actions Bot mentioned this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant