fix: CLI updates use installer scripts from the selected release#1190
Conversation
Installer downloads must come from the selected CLI release so update commands remain reproducible and do not depend on mutable branch refs. This keeps Unity editor installs and Go CLI self-updates aligned with the release asset version they install.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughRefactors CLI installer URL construction to use GitHub release tags ( ChangesCLI Installer URL Release-Tag Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Name the sample CLI versions used by NativeCliInstaller tests so the release URL assertions read as fixtures instead of current-version hardcoding.
Provide a release-tag smoke helper so release automation can verify that the selected CLI tag exposes the installer scripts consumed by Unity Settings and CLI updates. Run it after creating the release tag and before uploading assets so missing tagged scripts fail the release workflow immediately.
Summary
User Impact
mainorv3-betabranch content..ps1and.shinstaller scripts that updates will use.Changes
scripts/install.ps1andscripts/install.shunder a specified release tag.Verification
go test ./internal/update ./internal/cliuloop compileuloop run-tests --test-mode EditMode --filter-type regex --filter-value ".*NativeCliInstallerTests.*"scripts/check-go-cli.shscripts/test-check-release-installer.ps1on Windows PowerShellscripts/test-check-release-installer.ps1onpwshscripts/test-native-cli-publish-workflow.shscripts/check-release-installer.ps1 -Version cli-v3.0.0-beta.13codex-review v3-betawith no accepted/actionable findings