fix: Player builds stay free of editor-only uLoop tooling#1229
Merged
Conversation
Wrap prefab-attached visualization MonoBehaviours in UNITY_EDITOR so Player builds do not compile the mouse, keyboard, record, and replay overlay components. Add a prefab contract guard to keep those component sources editor-only while preserving Editor prefab references.
Mark the shared input visualization prefabs and their overlay GameObjects with Unity's EditorOnly tag as an additional guard against Player build inclusion. Add an EditMode prefab contract test so future prefab changes keep the tag intact.
Wrap the remaining runtime overlay support sources with UNITY_EDITOR so player builds retain only a minimal generated runtime assembly while editor prefab attachment and existing asmdef contracts stay unchanged.
Bundled Roslyn support assemblies are required only by the editor dynamic-code pipeline. Mark them Editor-only so Unity does not expose them to player assembly resolution, and add an importer test for the setting.
Document the Microsoft NuGet package sources and MIT license text for the bundled CodeAnalysis support assemblies distributed with the Unity package.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (21)
📝 WalkthroughWalkthroughThis PR gates 18 runtime overlay and input-simulation types to editor-only compilation using ChangesEditor-only gating and validation for input overlays
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User Impact
Changes
Verification