chore: Release PR checks no longer fail on an environment-dependent unit test - #1326
Conversation
GitHub Actions sets GITHUB_HEAD_REF for every step of pull_request runs, so on the release-please release PR the inherited release-please--branches--v3-beta value made the release-please skip fire before the base-ref skip under test, failing build-cli on the release PR itself. The test now controls GITHUB_HEAD_REF explicitly like the architecture test harness already does.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTest ChangesTest environment fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
build-clifailure that reappeared on the regenerated release PR (chore: release v3-beta #1278) after chore: Unblock the v3-beta release: align the next CLI release with the stamped version and stop release PRs failing the CLI version check #1325.User Impact
TestMinimumVersionWarningSkipsMissingBaseRefBeforeRepositoryResolutionfailed when the test suite ran on the release PR's own CI, keeping the release blocked.Changes
GITHUB_HEAD_REFfor every step ofpull_requestruns. On the release PR that value isrelease-please--branches--v3-beta, so the release-please skip introduced in chore: Unblock the v3-beta release: align the next CLI release with the stamped version and stop release PRs failing the CLI version check #1325 fired before the base-ref skip the test asserts. The test now clearsGITHUB_HEAD_REFexplicitly, the same way the architecture test harness already controls it.Verification
GITHUB_HEAD_REF=release-please--branches--v3-beta GITHUB_BASE_REF=v3-beta go test ./... -count=1reproduced the CI failure before the fix and passes after itscripts/check-go-cli.sh: all green