fix: Windows dynamic code snippets are easier to pass safely#1346
Conversation
Preserve multiline --code coverage for execute-dynamic-code and make the CLI-side --code-file option discoverable in help and completion. Document the native Windows launcher expectation because legacy npm shims can alter multiline PowerShell arguments before the Go CLI receives them.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds ChangesCLI:
Documentation: PowerShell Quoting and SKILL.md Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
2 issues found across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Only show the multiline PowerShell warning when the shadowing command is detected as a legacy npm shim, and centralize the warning text so installer messages stay consistent.
Summary
User Impact
uloopreceived them.--code-file, and the skill guidance explains when inline--codeis safe, when escaping is required, and when a legacy npm shim can still interfere.Changes
--code-fileinexecute-dynamic-code --helpand shell completion option lists.--codearguments and for listing the CLI-side file option.Verification
bash -lc 'cd /mnt/c/Users/booql/oss/unity-cli-loop2 && scripts/check-go-cli.sh'go test ./...go run ./cmd/uloop execute-dynamic-code --helpgo run ./cmd/uloop --list-options execute-dynamic-codecodex-review v3-beta