Skip to content

fix: Release PRs explain release component roles#1437

Merged
hatayama merged 1 commit into
v3-betafrom
fix/release-pr-component-label
Jun 29, 2026
Merged

fix: Release PRs explain release component roles#1437
hatayama merged 1 commit into
v3-betafrom
fix/release-pr-component-label

Conversation

@hatayama

@hatayama hatayama commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Release PRs now explain which entries are Unity package releases, project runner releases, and dispatcher releases.
  • The follow-up commit uses a releasable fix prefix so release-please can include this release workflow correction.

User Impact

  • Before this change, release reviewers could mistake multiple release components for duplicate Unity package releases.
  • After this change, the release PR header describes the three release lanes and their tag formats before the generated component sections.

Changes

  • Add a release-please pull request header documenting unity-package, uloop-project-runner, and dispatcher release roles.
  • Extend the release-please config test so the header cannot silently lose those role descriptions.

Verification

  • scripts/test-release-please-config.sh
  • scripts/test-sync-release-please-package-releases.sh
  • git diff --check

References:

Review in cubic

Add a release-please pull request header that distinguishes Unity package, project runner, and dispatcher releases so release reviewers do not mistake multiple components for duplicate Unity package releases.
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 57d052ed-3723-41ab-b7d8-7fa301f0816c

📥 Commits

Reviewing files that changed from the base of the PR and between fea7567 and 6573107.

📒 Files selected for processing (2)
  • release-please-config.json
  • scripts/test-release-please-config.sh

📝 Walkthrough

Walkthrough

Updates the pull-request-header field in release-please-config.json to document release components and version tag sources. Adds three corresponding test assertions in scripts/test-release-please-config.sh to verify the header contains unity-package, uloop-project-runner, and Dispatcher releases.

Changes

pull-request-header update and validation

Layer / File(s) Summary
Config update and test assertions
release-please-config.json, scripts/test-release-please-config.sh
pull-request-header text is updated to name release components and tag sources; three assert_json_value checks are added to validate the new substrings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • hatayama/unity-cli-loop#1244: Also modifies scripts/test-release-please-config.sh to extend assertions around release-please configuration expectations.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: improving release PRs to explain component roles.
Description check ✅ Passed The description is directly related to the config and test updates described in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-pr-component-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

You’re at about 92% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@hatayama
hatayama merged commit a2824fa into v3-beta Jun 29, 2026
6 checks passed
@hatayama
hatayama deleted the fix/release-pr-component-label branch June 29, 2026 17:24
This was referenced Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant