Skip to content

fix: Remove the dispatcher contract integer generation - #1504

Merged
hatayama merged 2 commits into
v3-betafrom
refactor/remove-dispatcher-contract-generation
Jul 5, 2026
Merged

fix: Remove the dispatcher contract integer generation#1504
hatayama merged 2 commits into
v3-betafrom
refactor/remove-dispatcher-contract-generation

Conversation

@hatayama

@hatayama hatayama commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

Part 3 of the version-gate consolidation (G4), following #1501 and #1503. The dispatcher and the Unity package were double-gated: an integer generation (dispatcherContractVersion vs REQUIRED_DISPATCHER_CONTRACT_VERSION, compared through --version --json) on top of the semver floor the pin's minimumDispatcherVersion already enforces. The dispatcher self-updates and releases monotonically, so the floor alone expresses capability requirements — the equality gate only added a value to keep in sync (it was never bumped from 1). The embedded contract JSONs' schemaVersion fields gated nothing because the JSON is compiled into the same binary that parses it.

After this PR the IPC protocolVersion is the only integer compatibility generation in the system.

  • Drop dispatcherContractVersion and schemaVersion from dispatcher-contract.json and schemaVersion from contract.json, with their parse gates and getters
  • Stop emitting DispatcherContractVersion from --version --json and stop parsing it in CliInstallationDetector
  • Delete the check-dispatcher-contract guard, its cmd, and its workflow step; shrink the dispatcher minimum version guard accordingly
  • Unify clicore.Version() / clicore.ProtocolVersion() onto clicontract, which owns the embedded contract data
  • Refresh shared-inputs stamps for the cli/common contract change

Validation

  • scripts/check-go-cli.sh, scripts/test-release-please-config.sh, scripts/test-stamp-release-inputs.sh, scripts/test-resolve-dispatcher-release-target.sh
  • check-release-triggers: passed (common change paired with dispatcher and project-runner touches)
  • uloop compile: 0 errors / 0 warnings; CliInstallationDetectorTests: 15/15 passed
  • uloop --version --json now emits only DispatcherVersion

Review in cubic

hatayama added 2 commits July 5, 2026 14:25
…Versions

The dispatcher and the Unity package were double-gated: an integer
generation (dispatcherContractVersion vs REQUIRED_DISPATCHER_CONTRACT_VERSION,
compared through --version --json) on top of the semver floor the pin's
minimumDispatcherVersion already enforces. The dispatcher self-updates and
releases monotonically, so the floor alone expresses capability requirements
and the equality gate only added a value to keep in sync (it was never
bumped). The embedded contract JSONs' schemaVersion fields gated nothing
because the JSON is compiled into the same binary that parses it.

The IPC protocolVersion is now the only integer compatibility generation in
the system.

- Drop dispatcherContractVersion and schemaVersion from dispatcher-contract.json
  and schemaVersion from contract.json, with their parse gates and getters
- Stop emitting DispatcherContractVersion from --version --json and stop
  parsing it in CliInstallationDetector
- Delete the check-dispatcher-contract guard, its cmd, and its workflow step;
  shrink the dispatcher minimum version guard accordingly
- Refresh shared-inputs stamps for the cli/common contract change
clicore.Version() and clicore.ProtocolVersion() were pure pass-through
wrappers around clicontract, which owns the embedded contract data. Two
names for the same value invite divergence in call sites, so every caller
now reads clicontract directly and the wrappers are gone.
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2666cb02-ae5f-4831-8523-c5ccff40adc5

📥 Commits

Reviewing files that changed from the base of the PR and between adceaed and a4cdda4.

📒 Files selected for processing (33)
  • .github/workflows/build-and-test.yml
  • Assets/Tests/Editor/CliInstallationDetectorTests.cs
  • Packages/src/Editor/Domain/CliConstants.cs
  • Packages/src/Editor/Infrastructure/CLI/CliInstallationDetector.cs
  • cli/common/clicontract/contract.go
  • cli/common/clicontract/contract.json
  • cli/common/clicontract/contract_test.go
  • cli/common/clicore/runner_version.go
  • cli/common/clicore/tool_readiness.go
  • cli/dispatcher/dispatchercontract/contract.go
  • cli/dispatcher/dispatchercontract/contract_test.go
  • cli/dispatcher/dispatchercontract/dispatcher-contract.json
  • cli/dispatcher/internal/dispatcher/dispatcher_bootstrap_routing_test.go
  • cli/dispatcher/internal/dispatcher/dispatcher_download.go
  • cli/dispatcher/internal/dispatcher/dispatcher_test.go
  • cli/dispatcher/internal/dispatcher/dispatcher_version.go
  • cli/dispatcher/internal/dispatcher/run_help.go
  • cli/dispatcher/shared-inputs-stamp.json
  • cli/project-runner/internal/projectrunner/compile_wait.go
  • cli/project-runner/internal/projectrunner/connection_retry_flow.go
  • cli/project-runner/internal/projectrunner/control_play_mode_wait.go
  • cli/project-runner/internal/projectrunner/pause_point_logs.go
  • cli/project-runner/internal/projectrunner/pause_point_wait.go
  • cli/project-runner/internal/projectrunner/run_test.go
  • cli/project-runner/internal/projectrunner/runner_usage.go
  • cli/project-runner/shared-inputs-stamp.json
  • cli/release-automation/cmd/check-dispatcher-contract/main.go
  • cli/release-automation/internal/automation/contract_file_at_ref_test.go
  • cli/release-automation/internal/automation/dispatcher_contract_guard.go
  • cli/release-automation/internal/automation/dispatcher_contract_guard_test.go
  • cli/release-automation/internal/automation/dispatcher_minimum_version_guard.go
  • cli/release-automation/internal/automation/dispatcher_minimum_version_guard_test.go
  • scripts/test-resolve-dispatcher-release-target.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-dispatcher-contract-generation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 33 files

Re-trigger cubic

@hatayama
hatayama merged commit d2ddbce into v3-beta Jul 5, 2026
10 checks passed
@hatayama
hatayama deleted the refactor/remove-dispatcher-contract-generation branch July 5, 2026 05:45
@github-actions github-actions Bot mentioned this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant