Skip to content

chore: Clean up unused assembly references and legacy compile result aliases - #1508

Merged
hatayama merged 1 commit into
v3-betafrom
refactor/c0-remove-unused-asmdef-refs-and-aliases
Jul 5, 2026
Merged

chore: Clean up unused assembly references and legacy compile result aliases#1508
hatayama merged 1 commit into
v3-betafrom
refactor/c0-remove-unused-asmdef-refs-and-aliases

Conversation

@hatayama

@hatayama hatayama commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removes assembly references that the Application layer declares but never uses, and deletes the deprecated lowercase compile-result aliases.

User Impact

  • No runtime behavior change. This is internal cleanup that keeps the layered architecture boundaries honest: the Application assembly no longer claims dependencies on the internal API bridge, the runtime assembly, or the Input System.

Changes

  • UnityCLILoop.Application.asmdef: dropped the InternalAPIBridge, Runtime, and Unity.InputSystem references (grep confirmed zero usages) and the now-unneeded ULOOP_HAS_INPUT_SYSTEM version define, leaving only Domain and ToolContracts.
  • CompileController: removed the backward-compatibility error/warning alias properties on CompileResult; the sample editor windows under Assets/Editor/CompileCheckWindow now use Errors/Warnings directly.

Verification

  • dist/darwin-arm64/uloop compile → Success, 0 errors / 0 warnings
  • dist/darwin-arm64/uloop run-tests --filter-type regex --filter-value "Compile(SessionResultService|LifecycleWatchdog|StatusBridgeCommand)Tests" → 22/22 passed

Review in cubic

The Application assembly declared references to InternalAPIBridge,
UnityCLILoop.Runtime, and Unity.InputSystem (plus the
ULOOP_HAS_INPUT_SYSTEM version define) that no Application source
uses. The dead declarations weakened the layering claim that
Application depends only on Domain and ToolContracts.

CompileResult kept lowercase error/warning alias properties for
backward compatibility, which this project does not need. Callers in
the CompileCheckWindow samples now use the Errors/Warnings properties.

- Verified with uloop compile (0 errors / 0 warnings)
- Compile-related EditMode tests pass (22/22)
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a3282855-556e-480f-8cfc-f773df65e0ef

📥 Commits

Reviewing files that changed from the base of the PR and between 9eb972b and f66dd35.

⛔ Files ignored due to path filters (1)
  • Packages/src/Editor/Application/UnityCLILoop.Application.asmdef is excluded by none and included by none
📒 Files selected for processing (3)
  • Assets/Editor/CompileCheckWindow/CompileCheckerExample.cs
  • Assets/Editor/CompileCheckWindow/CompileEditorWindow.cs
  • Packages/src/Editor/FirstPartyTools/Compile/CompileController.cs
💤 Files with no reviewable changes (1)
  • Packages/src/Editor/FirstPartyTools/Compile/CompileController.cs

📝 Walkthrough

Walkthrough

CompileResult's backward-compatibility alias properties (error, warning) were removed and replaced by a new internal PreserveDetailsWhenForceRecompile flag set via constructor parameter. Dependent code in CompileEditorWindow and CompileCheckerExample was updated to reference Errors/Warnings instead of the removed lowercase properties.

Changes

CompileResult API Cleanup

Layer / File(s) Summary
CompileResult property changes
Packages/src/Editor/FirstPartyTools/Compile/CompileController.cs
Removed public error/warning alias properties and added internal PreserveDetailsWhenForceRecompile property wired from a new constructor parameter.
Update callers to use Errors/Warnings
Assets/Editor/CompileCheckWindow/CompileEditorWindow.cs, Assets/Editor/CompileCheckWindow/CompileCheckerExample.cs
Log message and diagnostic retrieval logic updated to use Errors/Warnings properties instead of the removed lowercase members.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: removing legacy compile-result aliases and cleaning up assembly references.
Description check ✅ Passed The description matches the changeset and clearly describes the alias removal and assembly reference cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/c0-remove-unused-asmdef-refs-and-aliases

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@hatayama
hatayama merged commit fff35fe into v3-beta Jul 5, 2026
10 checks passed
@hatayama
hatayama deleted the refactor/c0-remove-unused-asmdef-refs-and-aliases branch July 5, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant