chore: Clean up unused assembly references and legacy compile result aliases - #1508
Conversation
The Application assembly declared references to InternalAPIBridge, UnityCLILoop.Runtime, and Unity.InputSystem (plus the ULOOP_HAS_INPUT_SYSTEM version define) that no Application source uses. The dead declarations weakened the layering claim that Application depends only on Domain and ToolContracts. CompileResult kept lowercase error/warning alias properties for backward compatibility, which this project does not need. Callers in the CompileCheckWindow samples now use the Errors/Warnings properties. - Verified with uloop compile (0 errors / 0 warnings) - Compile-related EditMode tests pass (22/22)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughCompileResult's backward-compatibility alias properties (error, warning) were removed and replaced by a new internal PreserveDetailsWhenForceRecompile flag set via constructor parameter. Dependent code in CompileEditorWindow and CompileCheckerExample was updated to reference Errors/Warnings instead of the removed lowercase properties. ChangesCompileResult API Cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
User Impact
Changes
UnityCLILoop.Application.asmdef: dropped the InternalAPIBridge, Runtime, and Unity.InputSystem references (grep confirmed zero usages) and the now-unneededULOOP_HAS_INPUT_SYSTEMversion define, leaving only Domain and ToolContracts.CompileController: removed the backward-compatibilityerror/warningalias properties onCompileResult; the sample editor windows underAssets/Editor/CompileCheckWindownow useErrors/Warningsdirectly.Verification
dist/darwin-arm64/uloop compile→ Success, 0 errors / 0 warningsdist/darwin-arm64/uloop run-tests --filter-type regex --filter-value "Compile(SessionResultService|LifecycleWatchdog|StatusBridgeCommand)Tests"→ 22/22 passed