Skip to content

chore: Remove redundant startup protection cleanup #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatayama merged 1 commit into from
Jul 6, 2026
Merged

chore: Remove redundant startup protection cleanup #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Packages/src/Editor/Infrastructure/Server/UnityCliLoopServerController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,8 @@ private void OnServerLoopUnexpectedlyExited()
// OnServerLoopExited fires from thread pool — marshal to main thread for Unity API safety
EditorApplication.delayCall += () =>
{
// The server just crashed — startup protection blocks recovery if the crash happens
// within the 5-second protection window after a successful start
_startupProtectionService.ClearStartupProtection();

VibeLogger.LogWarning(
Expand All @@ -353,11 +355,6 @@ private void OnServerLoopUnexpectedlyExited()

// Resources already cleaned up by CleanupAfterUnexpectedLoopExit — just clear the reference
_bridgeServer = null;

// The server just crashed — startup protection blocks recovery if the crash happens
// within the 5-second protection window after a successful start
_startupProtectionService.ClearStartupProtection();

_recoveryTrackingService.ScheduleTrackedRecovery(() => StartRecoveryIfNeededAsync(false, CancellationToken.None));
};
}
Expand Down
Loading