Skip to content

chore: Keep Input System setup guidance consistent#1607

Merged
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/share-input-system-warning-message
Jul 8, 2026
Merged

chore: Keep Input System setup guidance consistent#1607
hatayama merged 1 commit into
v3-betafrom
feature/hatayama/share-input-system-warning-message

Conversation

@hatayama

@hatayama hatayama commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Keeps the missing Input System package guidance consistent across first-party input tools.
  • Preserves the existing warning text while removing the duplicated string body.

User Impact

  • Projects without the Input System package continue to see the same setup guidance.
  • Future message updates can be made in one place, reducing the chance that one input tool drifts from the others.

Changes

  • Added a shared formatter for the missing Input System package warning.
  • Updated record, replay, keyboard simulation, and mouse simulation fallbacks to use the shared formatter.
  • Added an Editor test that pins the existing warning text for all four tools.

Verification

  • dist/darwin-arm64/uloop compile --project-path "$(git rev-parse --show-toplevel)"
  • dist/darwin-arm64/uloop run-tests --project-path "$(git rev-parse --show-toplevel)" --test-mode EditMode --filter-type exact --filter-value "io.github.hatayama.UnityCliLoop.Tests.Editor.InputSystemPackageRequirementMessageTests"
  • git diff --cached --check

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49a94300-dc9b-4028-b0cd-858a3e2fa421

📥 Commits

Reviewing files that changed from the base of the PR and between 0eece41 and b7758c3.

⛔ Files ignored due to path filters (2)
  • Assets/Tests/Editor/InputSystemPackageRequirementMessageTests.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemPackageRequirementMessage.cs.meta is excluded by none and included by none
📒 Files selected for processing (6)
  • Assets/Tests/Editor/InputSystemPackageRequirementMessageTests.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemPackageRequirementMessage.cs
  • Packages/src/Editor/FirstPartyTools/RecordInput/RecordInputUseCase.cs
  • Packages/src/Editor/FirstPartyTools/ReplayInput/ReplayInputUseCase.cs
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/SimulateKeyboardUseCase.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/SimulateMouseInputUseCase.cs
✅ Files skipped from review due to trivial changes (2)
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/SimulateKeyboardUseCase.cs
  • Packages/src/Editor/FirstPartyTools/RecordInput/RecordInputUseCase.cs
🚧 Files skipped from review as they are similar to previous changes (4)
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemPackageRequirementMessage.cs
  • Packages/src/Editor/FirstPartyTools/ReplayInput/ReplayInputUseCase.cs
  • Assets/Tests/Editor/InputSystemPackageRequirementMessageTests.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/SimulateMouseInputUseCase.cs

📝 Walkthrough

Walkthrough

A shared InputSystemPackageRequirementMessage.Format(toolName) helper is added and used to build the missing Input System package message in four use cases. A new editor test fixture checks the formatted output for multiple tool names.

Changes

Input System Requirement Messaging

Layer / File(s) Summary
Message formatter and tests
Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemPackageRequirementMessage.cs, Assets/Tests/Editor/InputSystemPackageRequirementMessageTests.cs
New internal static class formats a shared warning message via Format(toolName), and a parameterized test asserts expected output for multiple tool names.
Use case message adoption
Packages/src/Editor/FirstPartyTools/RecordInput/RecordInputUseCase.cs, Packages/src/Editor/FirstPartyTools/ReplayInput/ReplayInputUseCase.cs, Packages/src/Editor/FirstPartyTools/SimulateKeyboard/SimulateKeyboardUseCase.cs, Packages/src/Editor/FirstPartyTools/SimulateMouseInput/SimulateMouseInputUseCase.cs
Each use case's failure response under !ULOOP_HAS_INPUT_SYSTEM now sets Message via InputSystemPackageRequirementMessage.Format(toolName) instead of a hardcoded string.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • hatayama/unity-cli-loop#1516: Touches the same simulate-keyboard and simulate-mouse-input failure paths that now source their missing-package messages from the shared formatter.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: keeping Input System setup guidance consistent.
Description check ✅ Passed The description is directly related to the changes and accurately describes the shared formatter, updated fallbacks, and test coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/hatayama/share-input-system-warning-message

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Re-trigger cubic

Centralize the repeated missing Input System package guidance so the four input-tool fallback responses stay byte-identical through one formatter.
@hatayama
hatayama force-pushed the feature/hatayama/share-input-system-warning-message branch from 0eece41 to b7758c3 Compare July 8, 2026 08:41
@hatayama
hatayama merged commit 504c926 into v3-beta Jul 8, 2026
9 checks passed
@hatayama
hatayama deleted the feature/hatayama/share-input-system-warning-message branch July 8, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant