Skip to content

fix: Local skill packages no longer include stale cached skills#1615

Merged
hatayama merged 1 commit into
v3-betafrom
fix/hatayama/exclude-local-dependency-cache-roots
Jul 8, 2026
Merged

fix: Local skill packages no longer include stale cached skills#1615
hatayama merged 1 commit into
v3-betafrom
fix/hatayama/exclude-local-dependency-cache-roots

Conversation

@hatayama

@hatayama hatayama commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Local file: and path: skill packages no longer expose stale skills from an old PackageCache copy.
  • C# package discovery and the native CLI now apply the same local-dependency filtering contract.

User Impact

  • Previously, a project using a local package dependency could discover skills that existed only in a stale PackageCache directory with the same package identity.
  • Discovery now treats the local package root as authoritative and excludes that dependency identity from ordinary PackageCache candidates.

Changes

  • Reused the existing local-dependency resolvers in both C# and Go instead of introducing another file:/path: parser.
  • Added regression coverage for both dependency prefixes in the Unity package and native CLI.
  • Refreshed the project-runner and dispatcher shared-input stamps required by the common Go change.
  • Kept the Unity CLI Loop-specific cache fallback independent and unchanged. FindUnityCliLoopPackage now prefers the true local source when a stale cache exists, while its existing fallback path and tests remain intact.

Verification

  • Confirmed both new C# cases and both new Go subtests failed before the production fix and passed afterward.
  • scripts/check-go-cli.sh
  • dist/darwin-arm64/uloop compile --project-path "$(git rev-parse --show-toplevel)" (0 errors, 0 warnings)
  • SkillInstallLayoutTests (13 passed)
  • ToolSkillSynchronizerTests (52 passed)
  • git diff --check

Compatibility

  • The wire format is unchanged, so no protocol version bump is required.

Review in cubic

Local file: and path: manifest dependencies are authoritative skill package roots, but both C# and Go discovery also admitted same-name PackageCache entries. This could expose stale cache-only skills alongside the local package.

Filter local dependencies from PackageCache candidate identities by reusing the existing local-path resolvers in both implementations. Add regression coverage for both dependency prefixes and refresh the shared release input stamps required by the common Go change.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ef1330f6-a92e-4bf0-a31e-d3ff291507af

📥 Commits

Reviewing files that changed from the base of the PR and between 95270bb and 6b49a30.

📒 Files selected for processing (6)
  • Assets/Tests/Editor/SkillInstallLayoutTests.cs
  • Packages/src/Editor/Infrastructure/SkillSetup/SkillSourceRootEnumerator.cs
  • cli/common/skillscan/packages.go
  • cli/common/skillscan/packages_test.go
  • cli/dispatcher/shared-inputs-stamp.json
  • cli/project-runner/shared-inputs-stamp.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hatayama/exclude-local-dependency-cache-roots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@hatayama
hatayama merged commit 9388b91 into v3-beta Jul 8, 2026
10 checks passed
@hatayama
hatayama deleted the fix/hatayama/exclude-local-dependency-cache-roots branch July 8, 2026 12:28
@github-actions github-actions Bot mentioned this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant