Skip to content

chore: remove unused CommandRunner sync Execute entry point - #1745

Merged
hatayama merged 1 commit into
feature/dynamic-code-cancellation-hardeningfrom
chore/remove-dead-commandrunner-sync-execute
Jul 13, 2026
Merged

chore: remove unused CommandRunner sync Execute entry point#1745
hatayama merged 1 commit into
feature/dynamic-code-cancellation-hardeningfrom
chore/remove-dead-commandrunner-sync-execute

Conversation

@hatayama

@hatayama hatayama commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removes the unused public sync CommandRunner.Execute(ExecutionContext) API.
  • Raw-assembly sync fallback via ExecuteInternal / TryFindExecuteMethod is unchanged.

User Impact

  • No runtime behavior change. Production already uses ExecuteAsync only.

Changes

  • Deleted CommandRunner.Execute after DeadCodeScanner confirmed PublicCandidate (0 refs) and no release-please / contract / pin references.
  • Kept ExecuteInternal because ExecuteInternalAsync still calls it when no ExecuteAsync entry point exists.
  • Did not delete pre-existing dead Cancel() (not cascading from this removal).

Verification

  • DeadCodeScanner (CommandRunner.Execute was PublicCandidate; post-delete absent)
  • uloop compile 0/0
  • EditMode CommandRunnerCancellationTests|CompiledCommandEntryPointResolverTests 5/5

Refs

  • Explicit cleanup requested after PR 3-1 design note
  • Umbrella notes: /tmp/claude-shared/group3-umbrella-notes.md (marked deleted)

Made with Cursor

Review in cubic

DeadCodeScanner reported zero production and non-C# references. Keep
ExecuteInternal for the ExecuteInternalAsync raw-assembly sync fallback.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 37a08ba4-1dfd-43ad-a112-623223932c23

📥 Commits

Reviewing files that changed from the base of the PR and between 4506a7c and cf2ed17.

📒 Files selected for processing (1)
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Execution/CommandRunner.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-dead-commandrunner-sync-execute

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama

Copy link
Copy Markdown
Owner Author

LGTM (reviewer: Fable). Verified the deletion boundary: only the unreferenced sync Execute(ExecutionContext) entry point is removed, while ExecuteInternal stays because ExecuteAsync's raw-class sync fallback still calls it (line 278 at cf2ed17). Scanner result (PublicCandidate, no non-C# references) and leaving the separately-dead Cancel() for an explicit follow-up decision both match the dead-code policy.

@hatayama
hatayama merged commit 343e478 into feature/dynamic-code-cancellation-hardening Jul 13, 2026
2 checks passed
@hatayama
hatayama deleted the chore/remove-dead-commandrunner-sync-execute branch July 13, 2026 06:56
hatayama added a commit that referenced this pull request Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant