chore: remove unused CommandRunner sync Execute entry point - #1745
Conversation
DeadCodeScanner reported zero production and non-C# references. Keep ExecuteInternal for the ExecuteInternalAsync raw-assembly sync fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM (reviewer: Fable). Verified the deletion boundary: only the unreferenced sync Execute(ExecutionContext) entry point is removed, while ExecuteInternal stays because ExecuteAsync's raw-class sync fallback still calls it (line 278 at cf2ed17). Scanner result (PublicCandidate, no non-C# references) and leaving the separately-dead Cancel() for an explicit follow-up decision both match the dead-code policy. |
343e478
into
feature/dynamic-code-cancellation-hardening
Summary
CommandRunner.Execute(ExecutionContext)API.ExecuteInternal/TryFindExecuteMethodis unchanged.User Impact
ExecuteAsynconly.Changes
CommandRunner.Executeafter DeadCodeScanner confirmedPublicCandidate(0 refs) and no release-please / contract / pin references.ExecuteInternalbecauseExecuteInternalAsyncstill calls it when noExecuteAsyncentry point exists.Cancel()(not cascading from this removal).Verification
uloop compile0/0CommandRunnerCancellationTests|CompiledCommandEntryPointResolverTests5/5Refs
/tmp/claude-shared/group3-umbrella-notes.md(marked deleted)Made with Cursor