Skip to content

chore: Keep Editor package sources under 500 lines#1788

Merged
hatayama merged 8 commits into
v3-betafrom
feature/god-class-split-integration
Jul 14, 2026
Merged

chore: Keep Editor package sources under 500 lines#1788
hatayama merged 8 commits into
v3-betafrom
feature/god-class-split-integration

Conversation

@hatayama

@hatayama hatayama commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • dist/darwin-arm64/uloop compile → 0 errors / 0 warnings on integration tip
  • dotnet test tests/UnityCliLoop.CodeComplexity.Tests → 12 passed
  • dist/darwin-arm64/uloop run-tests --test-mode EditMode full suite (running)
  • find Packages/src/Editor -name '*.cs' | xargs wc -l → no file ≥500 (max ~489)
  • CI all green including CodeRabbit
  • Fable final review on the integration→v3-beta PR

Made with Cursor

Review in cubic

hatayama and others added 7 commits July 14, 2026 17:44
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cd6cf0ea-f51c-45ba-b139-8a493d61a464

📥 Commits

Reviewing files that changed from the base of the PR and between 0dffc75 and f8adfa0.

⛔ Files ignored due to path filters (50)
  • Assets/Tests/Editor/CompileLifecycleRecoveryCoordinatorTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/DynamicCodeToolTests/DynamicCodeLiteralHoisterCharacterizationTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/DynamicCodeToolTests/SourceShaperCharacterizationTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/ScreenshotUseCaseCharacterizationTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/ThirdPartyToolMigrationAssemblyUsageScanStateTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/ThirdPartyToolMigrationDomainRewriteCharacterizationTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/ToolSettingsSectionLayoutSignatureTests.cs.meta is excluded by none and included by none
  • Assets/Tests/PlayMode/InputReplayEventProcessorCharacterizationTests.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationApplicationAndFirstPartyTypeReplacementRules.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationCSharpLegacyAssemblyMigrationCapabilities.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationCSharpLegacyAssemblyMigrationContext.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationScreenshotCaptureWindowRewriteRules.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputRecorderFrameCapture.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputRecordingVectorFormat.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputReplayEventProcessor.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputReplayUiController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSimulationWaitTypes.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemConfiguredUpdateApplier.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemMainThreadAwaitable.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemRuntimeFrameWaiter.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemUpdateSubscription.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleError.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleErrorMessageFormatter.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleErrorResult.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Compile/CompileLifecycleRecoveryCoordinator.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Compile/ExternalPrefabStageChangeTracker.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeLiteralSyntaxScanner.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeRegularStringLiteralUnescaper.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SharedRoslynCompilerWorkerHostProcess.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SharedRoslynCompilerWorkerHostResults.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SourceTokenScanner.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/RaycastAnnotation/RaycastLayerSummaryBuilder.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/RaycastAnnotation/RaycastPhysicsColliderBuilder.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotCoordinateMetadata.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotFileWriter.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotParameterValidator.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotResponseFactory.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/UIElementAnnotationRenderer.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Screenshot/UIElementAnnotationStyling.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Infrastructure/CLI/CliShellInstallationProbe.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationAssemblyUsageReferenceRequirementRecorder.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/Setup/SetupWizardCliWorkflowController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/Setup/SetupWizardSkillsWorkflowController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/Setup/SetupWizardWorkflowController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardWorkflowController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolListRowData.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSectionLayoutSignature.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSectionListViewController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSectionRowBinder.cs.meta is excluded by none and included by none
  • Packages/src/Editor/Presentation/UnityCliLoopSettingsSkillsPresenter.cs.meta is excluded by none and included by none
📒 Files selected for processing (77)
  • Assets/Tests/Editor/AssemblyDefinitionConsoleErrorValidationServiceTests.cs
  • Assets/Tests/Editor/CliInstallationDetectorTests.cs
  • Assets/Tests/Editor/CompileLifecycleRecoveryCoordinatorTests.cs
  • Assets/Tests/Editor/CompileLifecycleWatchdogTests.cs
  • Assets/Tests/Editor/DynamicCodeToolTests/DynamicCodeLiteralHoisterCharacterizationTests.cs
  • Assets/Tests/Editor/DynamicCodeToolTests/SourceShaperCharacterizationTests.cs
  • Assets/Tests/Editor/ExternalSceneChangeResolverTests.cs
  • Assets/Tests/Editor/ScreenshotUseCaseCharacterizationTests.cs
  • Assets/Tests/Editor/StaticFacadeStateGuardTests.cs
  • Assets/Tests/Editor/ThirdPartyToolMigrationAssemblyUsageScanStateTests.cs
  • Assets/Tests/Editor/ThirdPartyToolMigrationDomainRewriteCharacterizationTests.cs
  • Assets/Tests/Editor/ToolSettingsSectionLayoutSignatureTests.cs
  • Assets/Tests/PlayMode/InputReplayEventProcessorCharacterizationTests.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationApplicationAndFirstPartyTypeReplacementRules.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationCSharpLegacyAssemblyMigrationCapabilities.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationCSharpLegacyAssemblyMigrationContext.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationCSharpRules.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationScreenshotCaptureWindowRewriteRules.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationScreenshotRules.cs
  • Packages/src/Editor/Domain/ThirdPartyToolMigrationTypeReplacementRules.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputRecorder.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputRecorderFrameCapture.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputRecordingVectorFormat.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputReplayEventProcessor.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputReplayUiController.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputRecording/InputReplayer.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSimulationWaitTypes.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemConfiguredUpdateApplier.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemMainThreadAwaitable.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemRuntimeFrameWaiter.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemUpdateHelper.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemUpdateSubscription.cs
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleError.cs
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleErrorMessageFormatter.cs
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleErrorResult.cs
  • Packages/src/Editor/FirstPartyTools/Compile/AssemblyDefinitionConsoleErrorValidationService.cs
  • Packages/src/Editor/FirstPartyTools/Compile/CompileController.cs
  • Packages/src/Editor/FirstPartyTools/Compile/CompileLifecycleRecoveryCoordinator.cs
  • Packages/src/Editor/FirstPartyTools/Compile/ExternalPrefabStageChangeTracker.cs
  • Packages/src/Editor/FirstPartyTools/Compile/ExternalSceneChangeTracker.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeLiteralHoister.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeLiteralSyntaxScanner.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeRegularStringLiteralUnescaper.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SharedRoslynCompilerWorkerHost.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SharedRoslynCompilerWorkerHostProcess.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SharedRoslynCompilerWorkerHostResults.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SourceShaper.cs
  • Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/SourceTokenScanner.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/RaycastAnnotation/RaycastGridAnnotator.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/RaycastAnnotation/RaycastLayerSummaryBuilder.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/RaycastAnnotation/RaycastPhysicsColliderBuilder.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotCoordinateMetadata.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotFileWriter.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotParameterValidator.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotResponseFactory.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/ScreenshotUseCase.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/UIElementAnnotationRenderer.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/UIElementAnnotationStyling.cs
  • Packages/src/Editor/FirstPartyTools/Screenshot/UIElementAnnotator.cs
  • Packages/src/Editor/Infrastructure/CLI/CliInstallationDetector.cs
  • Packages/src/Editor/Infrastructure/CLI/CliShellInstallationProbe.cs
  • Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationAssemblyUsageReferenceRequirementRecorder.cs
  • Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationAssemblyUsageScanState.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardCliWorkflowController.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardSkillsWorkflowController.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardWindow.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardWorkflowController.cs
  • Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardWindow.cs
  • Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardWorkflowController.cs
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolListRowData.cs
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSection.cs
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSectionLayoutSignature.cs
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSectionListViewController.cs
  • Packages/src/Editor/Presentation/UIToolkit/Components/ToolSettingsSectionRowBinder.cs
  • Packages/src/Editor/Presentation/UnityCliLoopSettingsCliSetupPresenter.cs
  • Packages/src/Editor/Presentation/UnityCliLoopSettingsSkillsPresenter.cs
  • Packages/src/Editor/Presentation/UnityCliLoopSettingsWindow.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/god-class-split-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The GetSelectedTargetInstallState* methods moved out of
UnityCliLoopSettingsWindow during the UI Extract Class split, so the
static facade guard must scan the presenter that now owns them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hatayama
hatayama merged commit b86e50f into v3-beta Jul 14, 2026
10 checks passed
@hatayama
hatayama deleted the feature/god-class-split-integration branch July 14, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant