fix: make recovery readiness checks reach Unity connection errors

[hatayama]

Summary

• Recovery/readiness smoke checks now exercise the intended Unity connection failure path for temporary projects.
• The self-test fixture supplies the runner pin required by the dispatcher.

User Impact

• Stale recovery-state validation no longer fails early with a project-resolution error.

Changes

• Copy the source project's .uloop/project-runner-pin.json into the temporary Unity project before running the stale-state check.
• Keep the fake project fixture aligned with the required project metadata.

Verification

• sh scripts/test-smoke-cli-recovery-readiness.sh
• go run scripts/smoke-cli-recovery-readiness.go --project-path /Users/a12115/ghq/hatayama/unity-cli-loop --uloop-path dist/darwin-arm64/uloop --timeout 120 --launch-timeout 240

Refs: Mac POSIX E2E recovery/readiness fix specification, To-Dos 2-4.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 610d0426-5d9a-4433-b09c-3c02fc3c1eb8

📥 Commits

Reviewing files that changed from the base of the PR and between 5f5566f and b8ea9b2.

📒 Files selected for processing (1)

• scripts/smoke-cli-recovery-readiness.go

🚧 Files skipped from review as they are similar to previous changes (1)

• scripts/smoke-cli-recovery-readiness.go

---

📝 Walkthrough

Walkthrough

The smoke-test harness prepares runner-pin metadata, passes the source project path into stale-recovery testing, and copies the pin into the temporary Unity project before writing stale server state.

Changes

Recovery pin setup

Layer / File(s)	Summary
Smoke harness pin preparation scripts/test-smoke-cli-recovery-readiness.sh	Creates the temporary project’s .uloop directory and copies project-runner-pin.json into it.
Temporary project pin propagation scripts/smoke-cli-recovery-readiness.go	Passes the source project path through stale recovery, copies the runner pin into the temporary project, and stops on copy errors before writing stale state.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• hatayama/unity-cli-loop#1139: Updates the CLI recovery/readiness smoke-test flow that this change extends.
• hatayama/unity-cli-loop#1501: Requires the project runner pin used by the updated temporary-project setup.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the main change: recovery readiness checks now reach the Unity connection error path.
Description check	✅ Passed	The description matches the changeset and explains the recovery/readiness smoke-test fix and verification steps.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/smoke-runner-pin

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}