Skip to content

fix: make input replay E2E parsing match V3 CLI responses#1830

Merged
hatayama merged 1 commit into
fix/macos-e2e-integrationfrom
fix/replay-json-casing
Jul 18, 2026
Merged

fix: make input replay E2E parsing match V3 CLI responses#1830
hatayama merged 1 commit into
fix/macos-e2e-integrationfrom
fix/replay-json-casing

Conversation

@hatayama

@hatayama hatayama commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Input record/replay E2E verification now reads the response fields emitted by the V3 CLI.
  • Automated replay validation completes instead of treating successful commands as empty or incomplete results.

User Impact

  • The input replay E2E no longer fails after a successful scene load or recording because of JSON key casing mismatches.

Changes

  • Use PascalCase for Success and Result checks.
  • Use PascalCase for OutputPath, IsReplaying, and Progress fields used by the remaining replay flow.

Verification

  • sh -n Assets/Tests/Demo/scripts/verify-replay-via-cli.sh
  • sh scripts/run-posix-e2e.sh --skip-recovery-readiness --skip-simulate-mouse
  • Output: RESULT: MATCH (11 events identical); All POSIX terminal-driven E2E checks passed.

Refs: Mac POSIX E2E recovery/readiness fix specification, To-Dos 5-6.

Review in cubic

Parse the PascalCase response fields emitted by the V3 CLI so recording paths, replay status, progress, success checks, and dynamic-code results are read correctly.
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a39e3fd3-59a0-4de1-ba51-b5b8c0bfa1a0

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae6771 and 870a5b1.

📒 Files selected for processing (1)
  • Assets/Tests/Demo/scripts/verify-replay-via-cli.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/replay-json-casing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 378a831 into fix/macos-e2e-integration Jul 18, 2026
2 checks passed
@hatayama
hatayama deleted the fix/replay-json-casing branch July 18, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant