Skip to content

fix: use Game View size tool in simulate mouse E2E#1833

Merged
hatayama merged 1 commit into
fix/macos-e2e-integrationfrom
fix/use-game-view-size-tool-in-e2e
Jul 18, 2026
Merged

fix: use Game View size tool in simulate mouse E2E#1833
hatayama merged 1 commit into
fix/macos-e2e-integrationfrom
fix/use-game-view-size-tool-in-e2e

Conversation

@hatayama

@hatayama hatayama commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the reflection-based Game View size selection and selectedSizeIndex restore in scripts/test-simulate-mouse-demo.sh
  • use the first-party set-game-view-size tool for the Full HD setup
  • restore the previous pixel dimensions from the tool response during cleanup

Verification

  • sh -n scripts/test-simulate-mouse-demo.sh -> pass
  • selectedSizeIndex, System.Reflection, and the old Game View size index helpers are absent from the script
  • sh scripts/run-posix-e2e.sh --skip-recovery-readiness --skip-input-replay -> RESULT: PASS, All POSIX terminal-driven E2E checks passed., exit 0
  • with the initial resolution set to 1280x720, the E2E reported 1920x1080 (previous: 1280x720) and a post-run set-game-view-size read confirmed restoration to 1280x720

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 06b103ac-c127-42d8-bd92-f2f061ebd431

📥 Commits

Reviewing files that changed from the base of the PR and between 6cc54a0 and 84b0de7.

📒 Files selected for processing (1)
  • scripts/test-simulate-mouse-demo.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/use-game-view-size-tool-in-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit b8ae2d6 into fix/macos-e2e-integration Jul 18, 2026
2 checks passed
@hatayama
hatayama deleted the fix/use-game-view-size-tool-in-e2e branch July 18, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant