feat: get-watch-values now flags a value that looks frozen#1852
Merged
hatayama merged 1 commit intoJul 19, 2026
Merged
Conversation
Watch values only refresh while the Editor is paused on a changed frame, so a value that stays the same across several evaluations usually means the linked pause point has not been hit again - a recurring source of confusion in prior verification passes. Add a pure WatchValueFreezeHintEvaluator and surface its result as ValueFrozenHint on each watch entry, and mirror the new field in the shared Go/C# watch response contract.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds freeze-hint evaluation for repeated watch values, includes the hint in watch responses, updates the Go response model and shared JSON contract, and adds evaluator and serialization tests. ChangesWatch freeze hint
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WatchEntryResponse
participant WatchValueFreezeHintEvaluator
participant watchEntryResponse
WatchEntryResponse->>WatchValueFreezeHintEvaluator: EvaluateFreezeHint(history)
WatchValueFreezeHintEvaluator-->>WatchEntryResponse: Return hint or empty string
WatchEntryResponse->>watchEntryResponse: Serialize ValueFrozenHint
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hatayama
merged commit Jul 19, 2026
da95300
into
feature/pause-point-feedback-integration
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-watch-valuesnow flags a watch entry whose value looks stuck, instead of leaving an agent to wonder why it never changes.User Impact
ValueFrozenHintfield that explains this refresh model and suggests confirming the linked pause point has been hit again, once the last few evaluations came back identical.Changes
WatchValueFreezeHintEvaluator(TDD, no Editor dependency) that flags an entry when its most recent evaluations (successful and identical) meet a small threshold.WatchEntryResponse.FromEntryas a newValueFrozenHintfield.tests/contracts/watch_response_contract.json,watch_types.go) since a field addition needs both sides updated to keep the contract test green; wire-compatible, so no protocol version bump.Verification
dist/darwin-arm64/uloop compile --project-path <repo>- 0 errors, 0 warningsdist/darwin-arm64/uloop run-tests --project-path <repo> --filter-type regex --filter-value "Watch"- 32/32 passedscripts/check-go-cli.sh- 0 lint issues, all Go packages pass (project-runner: 4.744s)