Skip to content

feat: get-watch-values now flags a value that looks frozen#1852

Merged
hatayama merged 1 commit into
feature/pause-point-feedback-integrationfrom
feat/get-watch-values-freeze-hint
Jul 19, 2026
Merged

feat: get-watch-values now flags a value that looks frozen#1852
hatayama merged 1 commit into
feature/pause-point-feedback-integrationfrom
feat/get-watch-values-freeze-hint

Conversation

@hatayama

@hatayama hatayama commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • get-watch-values now flags a watch entry whose value looks stuck, instead of leaving an agent to wonder why it never changes.

User Impact

  • Watch values only refresh while the Editor is paused on a changed frame. Agents repeatedly re-reading a watch after a pause point had stopped re-triggering saw the same value forever with no explanation - a recurring source of confusion in prior verification passes.
  • Each watch entry now carries a ValueFrozenHint field that explains this refresh model and suggests confirming the linked pause point has been hit again, once the last few evaluations came back identical.

Changes

  • Added a pure WatchValueFreezeHintEvaluator (TDD, no Editor dependency) that flags an entry when its most recent evaluations (successful and identical) meet a small threshold.
  • Wired the hint into WatchEntryResponse.FromEntry as a new ValueFrozenHint field.
  • Mirrored the field addition in the shared Go/C# watch response contract (tests/contracts/watch_response_contract.json, watch_types.go) since a field addition needs both sides updated to keep the contract test green; wire-compatible, so no protocol version bump.

Verification

  • dist/darwin-arm64/uloop compile --project-path <repo> - 0 errors, 0 warnings
  • dist/darwin-arm64/uloop run-tests --project-path <repo> --filter-type regex --filter-value "Watch" - 32/32 passed
  • scripts/check-go-cli.sh - 0 lint issues, all Go packages pass (project-runner: 4.744s)
  • Repository CI does not run for PRs targeting this integration branch (only bot reviewers execute); the commands above are the local substitute for this PR, with full CI validation happening on the final integration PR into the release branch.

Review in cubic

Watch values only refresh while the Editor is paused on a changed frame,
so a value that stays the same across several evaluations usually means
the linked pause point has not been hit again - a recurring source of
confusion in prior verification passes. Add a pure WatchValueFreezeHintEvaluator
and surface its result as ValueFrozenHint on each watch entry, and mirror
the new field in the shared Go/C# watch response contract.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f58f1909-52ef-44b3-9255-6293f0579ee6

📥 Commits

Reviewing files that changed from the base of the PR and between ca47a55 and cb64404.

⛔ Files ignored due to path filters (2)
  • Assets/Tests/Editor/WatchValueFreezeHintEvaluatorTests.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Watch/WatchValueFreezeHintEvaluator.cs.meta is excluded by none and included by none
📒 Files selected for processing (6)
  • Assets/Tests/Editor/WatchResponseContractTests.cs
  • Assets/Tests/Editor/WatchValueFreezeHintEvaluatorTests.cs
  • Packages/src/Editor/FirstPartyTools/Watch/WatchTools.cs
  • Packages/src/Editor/FirstPartyTools/Watch/WatchValueFreezeHintEvaluator.cs
  • cli/project-runner/internal/projectrunner/watch_types.go
  • tests/contracts/watch_response_contract.json

📝 Walkthrough

Walkthrough

Adds freeze-hint evaluation for repeated watch values, includes the hint in watch responses, updates the Go response model and shared JSON contract, and adds evaluator and serialization tests.

Changes

Watch freeze hint

Layer / File(s) Summary
Freeze hint evaluation and tests
Packages/src/Editor/FirstPartyTools/Watch/WatchValueFreezeHintEvaluator.cs, Assets/Tests/Editor/WatchValueFreezeHintEvaluatorTests.cs
Evaluates the latest three successful watch values and returns a pause-point hint when they are identical; tests cover history length, value differences, older entries, and failures.
Watch response propagation and contracts
Packages/src/Editor/FirstPartyTools/Watch/WatchTools.cs, cli/project-runner/.../watch_types.go, tests/contracts/watch_response_contract.json, Assets/Tests/Editor/WatchResponseContractTests.cs
Populates ValueFrozenHint in watch entries and adds the field to the Go response type and shared serialized response contract.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant WatchEntryResponse
  participant WatchValueFreezeHintEvaluator
  participant watchEntryResponse
  WatchEntryResponse->>WatchValueFreezeHintEvaluator: EvaluateFreezeHint(history)
  WatchValueFreezeHintEvaluator-->>WatchEntryResponse: Return hint or empty string
  WatchEntryResponse->>watchEntryResponse: Serialize ValueFrozenHint
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding frozen-value detection to watch values.
Description check ✅ Passed The description is clearly related to the changeset and matches the implemented freeze-hint feature and contract updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/get-watch-values-freeze-hint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit da95300 into feature/pause-point-feedback-integration Jul 19, 2026
2 checks passed
@hatayama
hatayama deleted the feat/get-watch-values-freeze-hint branch July 19, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant