Skip to content

fix: Runner-owned command flags and help no longer require a dispatcher release - #1862

Merged
hatayama merged 2 commits into
v3-betafrom
feature/remove-completion-help-forwarding-integration
Jul 20, 2026
Merged

fix: Runner-owned command flags and help no longer require a dispatcher release#1862
hatayama merged 2 commits into
v3-betafrom
feature/remove-completion-help-forwarding-integration

Conversation

@hatayama

@hatayama hatayama commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Shell completion (TAB completion) is fully removed; completion is now a silent no-op stub so existing shell rc blocks keep starting up without errors.
  • Runner-owned native commands (await-pause-point, pause-point-status, list, sync, focus-window) now show command-specific --help from the pinned project runner instead of a hardcoded dispatcher table.
  • Outside a Unity project, help output gives clearer guidance for finding the full command list, and error messages for unresolved projects are consistent across native commands and Unity tool commands.

User Impact

  • Before: adding or changing a flag on a runner-owned command required a dispatcher release just to update its --help text, and that text could drift from what the pinned runner actually accepted.
  • After: runner-owned command flags can be added or changed in the project runner alone; the dispatcher forwards --help requests to the pinned runner, so help text can never disagree with the runner's actual behavior.
  • Shell completion is gone, but existing eval "$(uloop completion --shell zsh)" blocks in shell rc files keep working silently instead of breaking shell startup.

Changes

  • Project runner: added per-command --help output for runner-owned native commands (new native_command_help.go).
  • Dispatcher: removed shell completion generation/install/detection code, replaced completion with a minimal no-op stub, and routed runner-owned command --help through the normal project-resolution dispatch path to the pinned runner instead of a static local table.
  • Expanded outside-project help guidance (top-level --help, native command help, Unity tool command help) to consistently point at --project-path or running inside a project.
  • Moved pause-point flag name constants from the shared cli/common/clicore package into cli/project-runner, since only the runner needs them; this keeps future runner-only flag changes from requiring a combined dispatcher/runner release.
  • Removed the "Shell Completion" sections from README.md/README_ja.md and refreshed the release-trigger stamps for the shared cli/common changes.

Verification

  • scripts/check-go-cli.sh passes across all Go modules (fmt, vet, lint, tests, binary rebuild) — confirmed in both child PRs (feat: project runner commands can show their own detailed --help #1860, fix: Runner-owned command flags no longer force a dispatcher release #1861).
  • Manually confirmed await-pause-point --help --project-path <project> forwards to the pinned runner and returns its help text; completion --shell zsh is a silent no-op (empty stdout, exit 0); outside-project help for native and Unity tool commands both give the same friendly project-resolution guidance.
  • This PR merges into v3-beta, so check-release-triggers and the rest of repository CI run here for the first time for this change set (they do not run on PRs targeting an integration branch); verify all checks are green before merging.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5565d750-6dd7-4739-914d-8812d867758b

📥 Commits

Reviewing files that changed from the base of the PR and between 985d3fe and 3d73e55.

📒 Files selected for processing (23)
  • README.md
  • README_ja.md
  • cli/common/clicore/command_registry.go
  • cli/common/clicore/global_args.go
  • cli/dispatcher/internal/dispatcher/command_help.go
  • cli/dispatcher/internal/dispatcher/completion.go
  • cli/dispatcher/internal/dispatcher/completion_options.go
  • cli/dispatcher/internal/dispatcher/completion_test.go
  • cli/dispatcher/internal/dispatcher/dispatcher_bootstrap_routing_test.go
  • cli/dispatcher/internal/dispatcher/dispatcher_process.go
  • cli/dispatcher/internal/dispatcher/dispatcher_test.go
  • cli/dispatcher/internal/dispatcher/help_test.go
  • cli/dispatcher/internal/dispatcher/native_command_options.go
  • cli/dispatcher/internal/dispatcher/run_dispatcher.go
  • cli/dispatcher/internal/dispatcher/run_help.go
  • cli/dispatcher/shared-inputs-stamp.json
  • cli/project-runner/internal/projectrunner/native_command_help.go
  • cli/project-runner/internal/projectrunner/native_command_help_test.go
  • cli/project-runner/internal/projectrunner/pause_point_captured_variables_mode.go
  • cli/project-runner/internal/projectrunner/pause_point_wait.go
  • cli/project-runner/internal/projectrunner/run.go
  • cli/project-runner/internal/projectrunner/runner_usage_test.go
  • cli/project-runner/shared-inputs-stamp.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/remove-completion-help-forwarding-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 96e75f8 into v3-beta Jul 20, 2026
11 checks passed
@hatayama
hatayama deleted the feature/remove-completion-help-forwarding-integration branch July 20, 2026 03:11
@github-actions github-actions Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant