Skip to content

fix: Correct dispatcher version series back to the 3.0.0-beta line#1888

Merged
hatayama merged 1 commit into
v3-betafrom
fix/dispatcher-version-realign
Jul 20, 2026
Merged

fix: Correct dispatcher version series back to the 3.0.0-beta line#1888
hatayama merged 1 commit into
v3-betafrom
fix/dispatcher-version-realign

Conversation

@hatayama

@hatayama hatayama commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Dispatcher's version series is corrected back to the intended 3.0.0-beta.x line, matching the Unity package and project runner.

User Impact

  • The dispatcher component had drifted onto an unintended 3.1.0-beta.x series (caused by a one-off bootstrap release that release-please treated as a shipped 3.0.0), out of step with the other components on 3.0.0-beta.x.
  • After this change, the dispatcher version series is consistent with the rest of the project again, and subsequent beta releases continue from 3.0.0-beta.19 as intended. No functional changes to the dispatcher itself.

Changes

  • Roll back .release-please-manifest.json and dispatcher-contract.json's dispatcherVersion to 3.0.0-beta.19. Hand-editing dispatcher-contract.json is normally disallowed (release-please stamps it), but this is a one-time correction of an incorrect version series, called out explicitly in the commit message.
  • Add a 3.0.0-beta.19 CHANGELOG entry in the same commit as the manifest change, matching the release-sync script's requirement that both land together.
  • Update minimumDispatcherVersion in both project-runner-pin.json copies to 3.0.0-beta.19 so dispatcher_minimum_version_guard passes (pin minimum equals the in-tree dispatcherVersion).

Verification

  • cd cli/release-automation && go build ./... — success
  • go test ./internal/automation/ -run Dispatcher -v — all tests pass
  • jq -r '.["cli/dispatcher"]' .release-please-manifest.json, jq -r .dispatcherVersion cli/dispatcher/dispatchercontract/dispatcher-contract.json, jq -r .minimumDispatcherVersion Packages/src/project-runner-pin.json all return 3.0.0-beta.19
  • diff Packages/src/project-runner-pin.json .uloop/project-runner-pin.json — no difference

Review in cubic

An unintended dispatcher-v3.0.0 bootstrap release (from PR #1413,
merged 2026-06-27) made release-please treat 3.0.0 as already
shipped, pushing the dispatcher component onto a 3.1.0-beta series
while every other component (Packages/src, cli/project-runner)
stayed on 3.0.0-beta. The mis-created dispatcher-v3.0.0 release and
tag have been deleted; this commit rejoins the dispatcher to the
3.0.0-beta line at 3.0.0-beta.19.

- Roll back .release-please-manifest.json and
  dispatcher-contract.json's dispatcherVersion to 3.0.0-beta.19.
  Editing dispatcher-contract.json by hand is normally forbidden
  (release-please stamps it), but this is a one-time correction of
  an incorrect version series, not an ordinary release.
- Add a 3.0.0-beta.19 CHANGELOG entry in the same commit as the
  manifest change, since
  scripts/sync-release-please-package-releases.sh requires both to
  land together to recognize the release commit.
- Update minimumDispatcherVersion in both project-runner-pin.json
  copies to 3.0.0-beta.19 so dispatcher_minimum_version_guard passes
  (pin minimum == in-tree dispatcherVersion).
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Dispatcher version metadata, compatibility pins, the dispatcher contract, and the changelog were aligned from the 3.1.0-beta or 3.1.0-beta.16 lines to 3.0.0-beta.19.

Changes

Dispatcher version alignment

Layer / File(s) Summary
Version metadata and release record
.release-please-manifest.json, .uloop/project-runner-pin.json, Packages/src/project-runner-pin.json, cli/dispatcher/dispatchercontract/dispatcher-contract.json, cli/dispatcher/CHANGELOG.md
Release metadata, minimum dispatcher version pins, the contract version, and the changelog were updated to 3.0.0-beta.19.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: reverting dispatcher versioning back to the 3.0.0-beta line.
Description check ✅ Passed The description is clearly related and matches the version-series correction described in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dispatcher-version-realign

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.uloop/project-runner-pin.json:
- Line 4: Keep the dispatcher release pins aligned with the new minimum release
series by updating or explicitly validating dispatcherReleaseTag in both
.uloop/project-runner-pin.json:4-4 and Packages/src/project-runner-pin.json:4-4.
Apply the identical corrected tag in both mirrored files so legacy forced
updates remain consistent.

In `@cli/dispatcher/CHANGELOG.md`:
- Around line 3-5: Verify the release date in the 3.0.0-beta.19 changelog entry
and replace July 21, 2026 with the actual release date if the release is not
intentionally scheduled for that day.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a3132aa4-4772-413f-ae76-d2f8bada13f6

📥 Commits

Reviewing files that changed from the base of the PR and between 8897602 and 0f19b25.

📒 Files selected for processing (5)
  • .release-please-manifest.json
  • .uloop/project-runner-pin.json
  • Packages/src/project-runner-pin.json
  • cli/dispatcher/CHANGELOG.md
  • cli/dispatcher/dispatchercontract/dispatcher-contract.json

Comment thread .uloop/project-runner-pin.json
Comment thread cli/dispatcher/CHANGELOG.md
@hatayama

Copy link
Copy Markdown
Owner Author

@coderabbitai resolve

Both actionable comments are addressed inline above (replied on each thread): the dispatcherReleaseTag/dispatcherArchiveManifest fields are intentionally left untouched (they only get advanced by the automated pin-stamp process once the corresponding release with attested assets actually exists), and the changelog date is correct as today is 2026-07-21.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@hatayama Thanks for the clarification. The release-tag/archive-manifest behavior is intentional under the pin-stamp workflow, and the changelog date is correct. I’m withdrawing those concerns and resolving my review comments.


✏️ Learnings added
Learnt from: hatayama
URL: https://github.com/hatayama/unity-cli-loop/pull/1888

Timestamp: 2026-07-20T18:04:43.617Z
Learning: In this repository’s dispatcher release workflow, `dispatcherReleaseTag` and `dispatcherArchiveManifest` remain unchanged until the automated pin-stamp process advances them after the corresponding release has attested assets. A dispatcher version realignment alone must not update these fields.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

✅ Action performed

Comments resolved and changes approved.

@hatayama
hatayama merged commit ddaa473 into v3-beta Jul 20, 2026
12 checks passed
@hatayama
hatayama deleted the fix/dispatcher-version-realign branch July 20, 2026 18:05
@github-actions github-actions Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant