feat: Expand multidimensional array and dictionary previews in CapturedVariables

[hatayama]

Summary

• CapturedVariables previews for multidimensional arrays and dictionaries no longer degrade to a bare type-name string when nested a couple of field-access hops deep inside a captured variable.
• Enum values inside array/dictionary previews now render by name instead of their underlying integer.

User Impact

Before this fix, inspecting a captured variable like a Tetris board's _cells field (PieceType?[,]) showed only an opaque type-name string such as "System.Nullable\1[...PieceType][,]"-- no shape, no cell values. NestedDictionary<string, int> fields hit the same problem. Separately, even where a preview did expand, enum elements showed up as raw integers ([0,null,1]`) instead of readable names.

After this fix:

• Board._cells (and any array/dictionary of primitives, enums, or strings) previews as a real Shape/Elements (or key/value) structure at any nesting depth reachable from a captured variable.
• Enum elements render by name (["Alpha",null,"Beta"]), consistent with how a plain enum-typed local already renders.
• Collections whose elements are themselves non-primitive objects still fall back to a type name once the preview depth limit is reached -- this fix does not remove the depth limit, only exempts primitive/enum/string leaves from consuming it.

Changes

• SourcePausePointCollectionPreviewSerializer.cs:
  • Registered StringEnumConverter on the shared primitive JsonSerializer so enum values serialize by name.
  • Added IsJsonPrimitiveElementType/IsPrimitiveKeyValueDictionaryType to detect arrays/dictionaries whose elements (or keys and values) are all primitives, enums, or strings, and exempt those from the remainingDepth <= 0 fallback gate.

Verification

• dist/darwin-arm64/uloop compile --project-path .: 0 errors, 0 warnings
• dist/darwin-arm64/uloop run-tests --filter-type regex --filter-value "SourcePausePointVariableFormatterTests" --test-mode EditMode: 42/42 passed (6 new tests covering 1D/2D nullable-enum arrays, primitive-value dictionaries, and the two-hop nesting boundary for both, plus a boundary case confirming non-primitive collections still respect the depth limit)
• dist/darwin-arm64/uloop run-tests --filter-type regex --filter-value "SourcePausePoint" --test-mode EditMode: 124/124 passed, no regressions

[coderabbitai]

📝 Walkthrough

Walkthrough

The preview serializer now renders enum names and preserves JSON expansion for primitive arrays and dictionaries at depth limits. New formatter tests cover nullable enum arrays, nested field access, primitive dictionary serialization, and custom-object fallback behavior.

Changes

Pause point preview serialization

Layer / File(s)	Summary
Primitive preview serialization and depth handling Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollectionPreviewSerializer.cs	Enum values use names in JSON previews, while primitive arrays and dictionaries continue expanding at the depth limit; non-primitive collections still fall back to type names.
Nested nullable collection regression coverage Assets/Tests/Editor/SourcePausePointCapture/SourcePausePointVariableFormatterTests.cs	Tests and fixtures cover nullable enum array shapes, null elements, nested field access, primitive dictionaries, and custom-object dictionary fallback.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: expanding CapturedVariables previews for multidimensional arrays and dictionaries.
Description check	✅ Passed	The description is clearly related to the changeset and explains the preview fixes, behavior changes, and verification results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/pause-point-nullable-enum-array-preview

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollectionPreviewSerializer.cs (1)

126-129: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider supporting generic collections (like List<T>) for primitive JSON expansion at depth limits.

Currently, this depth-limit exception explicitly targets Array and IDictionary. This perfectly fulfills the PR's objective, but it means that a primitive list (e.g., List<int>) nested at the depth limit will still fall through isPrimitiveElementArray and degrade to a type-name string fallback.

If you want to allow all generic collections of primitives to remain JSON-expandable at depth limits, consider expanding this check to inspect IEnumerable<T> or ICollection<T> to cover common types like List<T> and HashSet<T>.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollectionPreviewSerializer.cs`
around lines 126 - 129, Extend the depth-limit primitive collection detection
around isPrimitiveElementArray to recognize generic IEnumerable<T> or
ICollection<T> implementations, including List<T> and HashSet<T>, while
preserving the existing array and dictionary checks. Ensure the element type is
validated with IsJsonPrimitiveElementType so only collections of JSON primitives
remain expandable.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollectionPreviewSerializer.cs`:
- Around line 126-129: Extend the depth-limit primitive collection detection
around isPrimitiveElementArray to recognize generic IEnumerable<T> or
ICollection<T> implementations, including List<T> and HashSet<T>, while
preserving the existing array and dictionary checks. Ensure the element type is
validated with IsJsonPrimitiveElementType so only collections of JSON primitives
remain expandable.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b2ecd05e-44c3-4cd4-bde6-de560cacb210

📥 Commits

Reviewing files that changed from the base of the PR and between 8e19067 and d28952d.

📒 Files selected for processing (2)

• Assets/Tests/Editor/SourcePausePointCapture/SourcePausePointVariableFormatterTests.cs
• Packages/src/Editor/FirstPartyTools/PausePoint/SourcePausePointCollectionPreviewSerializer.cs