fix: Silence a Unity 6000.5 compile warning in physics pause-point diagnostics#1928
Conversation
…EWER Unity 6000.5 marks Object.FindObjectsByType(Type, FindObjectsInactive, FindObjectsSortMode) obsolete (CS0618), which failed the Unity Compile Check's warning-zero gate on 6000.5.4f1 while 2022.3 (the local dev version) built clean. Branch on UNITY_6000_4_OR_NEWER the same way UiRaycastHelper.CollectCanvasRaycastSources already does: the sort-mode-free overload on 6000.4+, the existing three-argument call below it.
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f80dfca
into
feature/round7-pause-point-improvements
Summary
User Impact
Changes
Object.FindObjectsByType(Type, FindObjectsInactive, FindObjectsSortMode)is marked obsolete (CS0618) starting in Unity 6000.5, which failed the Unity Compile Check's warning-zero gate on 6000.5.4f1 (2022.3, the local dev version, built clean).LogPhysicsDispatchDiagnosticsbehindUNITY_6000_4_OR_NEWER, matching the existing pattern inUiRaycastHelper.CollectCanvasRaycastSources: the sort-mode-free overload on 6000.4+, the existing three-argument call below it otherwise.Verification
uloop compile(2022.3.62f3, this checkout's Unity version) -- 0 errors, 0 warnings.uloop run-tests --filter-type regex --filter-value "SourcePausePointPatcherTests" --test-mode EditMode-- 27/27 passed.