Skip to content

fix: Silence a Unity 6000.5 compile warning in physics pause-point diagnostics#1928

Merged
hatayama merged 1 commit into
feature/round7-pause-point-improvementsfrom
fix/physics-diagnostics-unity6000-obsolete
Jul 21, 2026
Merged

fix: Silence a Unity 6000.5 compile warning in physics pause-point diagnostics#1928
hatayama merged 1 commit into
feature/round7-pause-point-improvementsfrom
fix/physics-diagnostics-unity6000-obsolete

Conversation

@hatayama

@hatayama hatayama commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • No user-visible behavior change. Fixes a Unity 6000.5 compile warning that was failing the Round-7 integration PR's CI.

User Impact

  • N/A (internal-only fix; physics-callback pause point diagnostics behavior is unchanged on every Unity version).

Changes

  • Object.FindObjectsByType(Type, FindObjectsInactive, FindObjectsSortMode) is marked obsolete (CS0618) starting in Unity 6000.5, which failed the Unity Compile Check's warning-zero gate on 6000.5.4f1 (2022.3, the local dev version, built clean).
  • Guard the call in LogPhysicsDispatchDiagnostics behind UNITY_6000_4_OR_NEWER, matching the existing pattern in UiRaycastHelper.CollectCanvasRaycastSources: the sort-mode-free overload on 6000.4+, the existing three-argument call below it otherwise.

Verification

  • uloop compile (2022.3.62f3, this checkout's Unity version) -- 0 errors, 0 warnings.
  • uloop run-tests --filter-type regex --filter-value "SourcePausePointPatcherTests" --test-mode EditMode -- 27/27 passed.
  • The 6000.5 branch itself is only exercised by CI (this checkout runs 2022.3); confirming its warning-free compile there is the next step.

Review in cubic

…EWER

Unity 6000.5 marks Object.FindObjectsByType(Type, FindObjectsInactive,
FindObjectsSortMode) obsolete (CS0618), which failed the Unity Compile
Check's warning-zero gate on 6000.5.4f1 while 2022.3 (the local dev
version) built clean. Branch on UNITY_6000_4_OR_NEWER the same way
UiRaycastHelper.CollectCanvasRaycastSources already does: the
sort-mode-free overload on 6000.4+, the existing three-argument call
below it.
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 65b6dd8b-9b83-45bc-a3c8-b36a5753c1f4

📥 Commits

Reviewing files that changed from the base of the PR and between 2a23d97 and 0a51198.

📒 Files selected for processing (1)
  • Packages/src/Editor/FirstPartyTools/PausePoint/PausePointTools.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/physics-diagnostics-unity6000-obsolete

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit f80dfca into feature/round7-pause-point-improvements Jul 21, 2026
1 of 2 checks passed
@hatayama
hatayama deleted the fix/physics-diagnostics-unity6000-obsolete branch July 21, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant