Skip to content

Explicitly set working directory to executable directory on boot - #1430

Merged
blueskythlikesclouds merged 5 commits into
mainfrom
working-dir-fix
Mar 24, 2025
Merged

Explicitly set working directory to executable directory on boot#1430
blueskythlikesclouds merged 5 commits into
mainfrom
working-dir-fix

Conversation

@DeaTh-G

@DeaTh-G DeaTh-G commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Fixes #1271.

Comment thread UnleashedRecomp/main.cpp Outdated
@DeaTh-G
DeaTh-G marked this pull request as draft March 19, 2025 10:53
Comment thread UnleashedRecomp/main.cpp Outdated
@blueskythlikesclouds

Copy link
Copy Markdown
Member

Should add a cmd option to bypass this for development purposes.

@DeaTh-G

DeaTh-G commented Mar 19, 2025

Copy link
Copy Markdown
Contributor Author

Should add a cmd option to bypass this for development purposes.

Done, --use-cwd now allows to do that.

@DarioSamo

Copy link
Copy Markdown
Contributor

@blueskythlikesclouds Does this change fix the D3D12 Agility SDK not being found if ran from the search menu? What's the logic behind the loading of the Agility SDK? Does it wait for the backend to be attempted to be created first or does it attempt to load it on its own before we reach main()?

@blueskythlikesclouds

Copy link
Copy Markdown
Member

@blueskythlikesclouds Does this change fix the D3D12 Agility SDK not being found if ran from the search menu? What's the logic behind the loading of the Agility SDK? Does it wait for the backend to be attempted to be created first or does it attempt to load it on its own before we reach main()?

As far as I know it's delayed to when the device gets created. I can make a test to confirm the behavior.

@DeaTh-G
DeaTh-G marked this pull request as ready for review March 19, 2025 13:08
Comment thread UnleashedRecomp/main.cpp Outdated

@blueskythlikesclouds blueskythlikesclouds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a test, it still loads the D3D12Core.dll located in executable folder after changing the working directory.

@blueskythlikesclouds
blueskythlikesclouds merged commit 7f9ce50 into main Mar 24, 2025
@blueskythlikesclouds
blueskythlikesclouds deleted the working-dir-fix branch March 24, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running the game through the Windows Start Menu search bar causes multiple issues.

6 participants