Fix Options Menu sliders being frame-dependent at lower framerates - #677
Merged
Conversation
…holdTime variable, rather than the current frame's deltaTime
Contributor
|
@DarioSamo marked you for reviews as I think your expertise regarding frame rate dependent bugs could be used here. |
DarioSamo
reviewed
Mar 19, 2025
DarioSamo
requested changes
Mar 19, 2025
DarioSamo
left a comment
Contributor
There was a problem hiding this comment.
Haven't tested it personally but changes look good other than needing to address the comment I left, which was a problem with the original code.
Contributor
|
Framerate independence looks good to me. Double checking that someone else tests if it works as intended. |
DarioSamo
approved these changes
Mar 19, 2025
hyperbx
requested changes
Mar 23, 2025
hyperbx
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options menu sliders use their local deltaTime values to determine the fastIncrement logic, which causes issues at low framerates. Changed the logic to use a persistent variable and fixed a few related bugs (such as 1/119 dT and 1/120 INCREMENT_TIME causing two increments)