Skip to content

[BUG]: The "type" of rewards does not indicate the item awarded to the players #53

Description

@raginmari

Faulty File Path & Name

assignments/reward/type.json

Request information

The current major order has two different rewards: medals and requisition credits. Both rewards have type "1" while they differ in the "id32" item ID:

"rewards": [
    {
        "type": 1,
        "id32": 897894480,
        "amount": 45
    },
    {
        "type": 1,
        "id32": 3608481516,
        "amount": 29000
    }
]

So, the current assumption that "1" indicates the type of reward is wrong (see assignments/reward/type.json).

What is expected?

Hard to say: in the API, I would not expect an actual item ID to be used but a small set of reward type such as medals and requisitions. In this repository, I would probably expect the assignments/reward/type.json file to be removed?

What is actually happening?

See information above.

Any additional comments?

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions