Repository navigation
fix(issues): align severity colours and typography with theme tokens - #30
Merged
Merged
Conversation
The /issues page and AIInsightFeed hardcoded bright Tailwind colors (red-500, orange-500, emerald-500, raw #ef4444) for severity, so they ignored the active theme and clashed with the graphite paper surface — a 0/100 security score rendered in saturated red-500 instead of the muted --sev-crit. Add theme-aware `sev` (ok/info/warn/high/crit -> --sev-*) and `accent` (-> --accent) Tailwind color families and swap every hardcoded severity color to them. Decorative/link blues move to accent; the health ring's inline hex uses rgb(var(--sev-*)). Severity now follows all four themes. Closes #27
Closed
6 tasks
The issues page imported and applied DM Serif/Mono/Sans and used them in ~30 inline styles, so its ring number, counters and labels rendered in a different typeface than the rest of Hetu (Fraunces/Inter/JetBrains Mono) and did not re-theme with the four-theme system. Point every font at the theme vars (--font-display/-mono/-body), drop the DM next/font imports, and swap text-white on the crit badge to text-cluster-bg so it stays readable on the lighter --sev-crit in dark themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the
/issuespage (and the AI Insights feed) with Hetu's theme system —both colour and typography.
Colours (Closes #27)
The page hardcoded bright Tailwind colours (
red-500,orange-500,emerald-500,raw
#ef4444…) for severity, ignoring the active theme — a 0/100 security score renderedin saturated
red-500instead of the muted--sev-crit.sev(ok/info/warn/high/crit→--sev-*) andaccent(→--accent) colour families.colour →
sev-*tokens; health-ring inline hex →rgb(var(--sev-*)); decorative/linkblues →
accent.Typography
The page imported and applied DM Serif / DM Mono / DM Sans and used them in ~30 inline
styles, so its ring number, counters and labels rendered in a different typeface than the
rest of Hetu and did not re-theme.
var(--font-display)/var(--font-mono)/var(--font-body)(Fraunces / JetBrains Mono / Inter); drop the DMnext/fontimports.text-whiteon the crit badge →text-cluster-bgso it stays readable on the lighter--sev-critin dark themes.Severity colour and type now follow all four themes (graphite, calm-signal, aurora, prism).
Testing
pnpm test:e2e theme-tokens→ asserts the critical counter resolves torgb(155, 28, 46)(
--sev-crit) notrgb(239, 68, 68), the critical dot fills with--sev-crit, no elementin
<main>uses the bright Tailwind palette, and no element resolves to a DM font.pnpm exec tsc --noEmitandpnpm exec eslint→ clean.mainand are unrelated — tracked in e2e: home-page CriticalBanner + version-display specs fail (empty SSE stream / flaky nav) #31.Closes #27