fix(dashboard): always surface a critical banner for scores <= 25 - #32
Merged
Merged
Conversation
CriticalBanner rendered a reassuring green "LOW SCORES" bar whenever findingsCount was 0, so a 0/100 security score showed green instead of a critical alert — and the incident-command specs (which expect a CRITICAL banner for scores <= 25) failed deterministically. A dimension in the critical band is a critical alert regardless of separately-counted findings. Drop the findings-gated green branch and the now-unused findingsCount prop; always render the red CRITICAL banner with the View findings action. Closes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CriticalBanner showed a reassuring green "LOW SCORES" bar when
findingsCountwas 0, so a 0/100 security score rendered green instead of a critical alert — andincident-command.spec.ts:18/:33failed deterministically.A dimension in the critical band (<= 25) is a critical alert regardless of separately-counted findings. Removed the findings-gated green branch and the unused
findingsCountprop; the red CRITICAL banner with the View findings action now always renders for a critical score.Testing
incident-commandspec: 14/14 pass (previously:18/:33failed).tsc+eslintclean.workers: 1) withretries: 2.Closes #31