Expose tag for unresolved links - #27
Merged
Merged
Conversation
hellux
force-pushed
the
unresolved_links
branch
2 times, most recently
from
March 19, 2023 13:19
004c8af to
ba6e0b5
Compare
better to provide the original url, the event is already tagged as email also avoids a string allocation
keep the tag for unresolved links, and allow distinguishing between `[tag][tag with empty url]` and `[tag][non-existent tag]`. closes #26
hellux
force-pushed
the
unresolved_links
branch
from
March 20, 2023 22:41
ba6e0b5 to
3b12052
Compare
hellux
added a commit
that referenced
this pull request
Apr 5, 2023
Merge branch 'unresolved_links' closes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after some discussion in #14, #26
also contains some other small fixes to things that I discovered while adding this.