Repository navigation
Skip location expansion for literal rust-analyzer environment values - #76
Merged
Merged
Conversation
Call ctx.expand_location only for environment values containing $(, since other values cannot contain location macros. Forward literal values unchanged to avoid unnecessary expansion calls during rust-analyzer aspect analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
ctx.expand_locationonly for rust-analyzer environment values containing$(. Literal values remain unchanged and avoid unnecessary location expansion during aspect analysis.Validation: generated-source and proc-macro-dylib analysis tests both pass; buildifier and
git diff --checkpass.-zbarskybot