Repository navigation
fix: Mitigate the -L dependency= consolidation races on Windows under cc_common.link - #82
Merged
Conversation
… `cc_common.link` Keep `.a` files out of the unified dependency directory of the Windows process wrapper. On Windows, `process_wrapper` merges every `-Ldependency=` directory into one, to keep the command line short. It scans each directory with `read_dir`, so it also sees files that are no input of the action. `rules_rust` puts a `lib<name>.a` symlink next to each rlib, for `cc_common.link`. With `experimental_use_cc_common_link`, Bazel builds those symlinks while sibling `Rustc` actions scan the directory, and the copy fails with "Access is denied". `-L dependency=` only searches for crates, and no crate is a `.a` file, so skip the extension. Relates to hermeticbuild#48
ArchangelX360
force-pushed
the
archangelx360/races
branch
from
October 5, 2026 13:49
882fcfc to
dae8132
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep
.afiles out of the unified dependency directory of the Windows process wrapper.On Windows,
process_wrappermerges every-Ldependency=directory into one, to keep the command line short. It scans each directory withread_dir, so it also sees files that are no input of the action.rules_rustputs alib<name>.asymlink next to each rlib, forcc_common.link. Withexperimental_use_cc_common_link, Bazel builds those symlinks while siblingRustcactions scan the directory, and the copy fails with "Access is denied".-L dependency=only searches for crates, and no crate is a.afile, so skip the extension.Relates to #48