Repository navigation
Conversation
This was referenced Oct 8, 2026
Draft
cerisier
marked this pull request as ready for review
October 8, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of bazelbuild#4321 onto this fork's main, preserving its existing path mapper and user compile-flag regressions. This is the copy needed by consumers such as rules_rs that pin hermeticbuild/rules_rust.
Cargo build scripts change working directory, so execroot-relative header operands must be made absolute. Recognize
-internal-externc-isystemand preserve-Xpreprocessorwhile awaiting the header path, just as for-Xclang. Otherwise Clang loses libc headers, producing errors such asstdlib.hnot found. Absolute paths and unrelated flags stay unchanged.Eight generated-action regressions cover both forwarding forms, both header categories, and relative/absolute operands. The corresponding tests expose three missing rewrites on upstream's unmodified baseline. All 40 tests in this fork's flag-handling package pass:
USE_BAZEL_VERSION=8.6.0 bazel test --config=remote --lockfile_mode=off \ --local_test_jobs=1 //cargo/tests/cargo_build_script/cc_args_and_env:allThe first concurrent macOS run hit a
generate-xml.shsegmentation fault on the existingbindir_relative_test; the sequential retry passed all 40 tests. Buildifier formatting/lint and whitespace checks pass.Merge blocker for hermeticbuild/hermetic-llvm#819 and hermeticbuild/hermetic-llvm#820, alongside the bazelbuild PR. Consumers must adopt a release or pin containing this fix before the hermetic-llvm stack merges.