feat: add --no-cache flag to container:push (W-23597904, #1390) - #3840
Open
heroku-johnny wants to merge 3 commits into
Open
feat: add --no-cache flag to container:push (W-23597904, #1390)#3840heroku-johnny wants to merge 3 commits into
heroku-johnny wants to merge 3 commits into
Conversation
Adds a --no-cache boolean flag to `heroku container:push` that passes `--no-cache` to the underlying `docker build` command, allowing users to bypass the Docker layer cache on demand. Resolves GitHub issue #1390. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with 
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 21:47 — with
GitHub Actions
Inactive
heroku-johnny
had a problem deploying
to
AcceptanceTests
July 27, 2026 21:47 — with
GitHub Actions
Error
heroku-johnny
had a problem deploying
to
AcceptanceTests
July 27, 2026 21:47 — with
GitHub Actions
Failure
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 21:47 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 28, 2026 20:04 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 28, 2026 20:04 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 28, 2026 20:04 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 28, 2026 20:04 — with
GitHub Actions
Inactive
michaelmalave
approved these changes
Aug 4, 2026
michaelmalave
left a comment
Contributor
There was a problem hiding this comment.
Added a comment on user facing text added. Otherwise, code passes. LGTM
| app: flags.app({required: true}), | ||
| arg: flags.string({description: 'set build-time variables'}), | ||
| 'context-path': flags.string({description: 'path to use as build context (defaults to Dockerfile dir)'}), | ||
| 'no-cache': flags.boolean({description: 'do not use cache when building the image'}), |
Contributor
There was a problem hiding this comment.
User facing text. Might need CX review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-cacheboolean flag toheroku container:push--no-cacheto the underlyingdocker buildcommand when the flag is setnoCache?: booleanto theBuildImageParamstype inDockerHelperTest plan
npm run test:file test/unit/lib/container/docker-helper.unit.test.ts— 2 new tests fornoCache: trueandnoCache: falsenpm run test:file test/unit/commands/container/push.unit.test.ts— 1 new test verifying--no-cacheis passed through tobuildImagenpx eslint src/lib/container/docker-helper.ts src/commands/container/push.ts— no errorsCloses #1390
🤖 Generated with Claude Code