feat(pg,redis): add --as flag to pg:promote and redis:promote (W-23597911, #1819) - #3841
Open
heroku-johnny wants to merge 3 commits into
Open
feat(pg,redis): add --as flag to pg:promote and redis:promote (W-23597911, #1819)#3841heroku-johnny wants to merge 3 commits into
heroku-johnny wants to merge 3 commits into
Conversation
…tom attachment names Resolves W-23597911 / GitHub #1819. Previously, both commands hardcoded the attachment name (DATABASE and REDIS respectively). With this change, users can pass --as NAME to create the promoted attachment under a custom name, falling back to the original default when the flag is omitted. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 20:07 — with
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 21:45 — with
GitHub Actions
Inactive
heroku-johnny
had a problem deploying
to
AcceptanceTests
July 27, 2026 21:45 — with
GitHub Actions
Failure
heroku-johnny
temporarily deployed
to
AcceptanceTests
July 27, 2026 21:45 — with
GitHub Actions
Inactive
heroku-johnny
had a problem deploying
to
AcceptanceTests
July 27, 2026 21:45 — with
GitHub Actions
Error
michaelmalave
temporarily deployed
to
AcceptanceTests
August 4, 2026 17:34 — with
GitHub Actions
Inactive
michaelmalave
temporarily deployed
to
AcceptanceTests
August 4, 2026 17:34 — with
GitHub Actions
Inactive
michaelmalave
temporarily deployed
to
AcceptanceTests
August 4, 2026 17:34 — with
GitHub Actions
Inactive
michaelmalave
temporarily deployed
to
AcceptanceTests
August 4, 2026 17:34 — with
GitHub Actions
Inactive
michaelmalave
approved these changes
Aug 4, 2026
michaelmalave
left a comment
Contributor
There was a problem hiding this comment.
Nice! Testing successful and code passes checks. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--as NAMEflag toheroku pg:promote— allows creating the promoted database attachment under a custom name instead of the hardcodedDATABASE--as NAMEflag toheroku redis:promote— allows creating the promoted Key-Value Store attachment under a custom name instead of the hardcodedREDIS--asis omitted both commands fall back to the original default names, so existing behavior is unchangedflags.aspattern already established inaddons:attachandpg:connection-pooling:attachResolves GUS W-23597911 / GitHub #1819
Test plan
pg:promoteunit tests pass, including new test for--as CUSTOM_DBwhich asserts the attachment POST sendsname: 'CUSTOM_DB'redis:promoteunit tests pass, including new test for--as CUSTOM_REDISwhich asserts the attachment POST sendsname: 'CUSTOM_REDIS'heroku pg:promote --app <app> <db> --as STAGING_DBcreates attachment namedSTAGING_DB_URLheroku redis:promote --app <app> <redis> --as STAGING_REDIScreates attachment namedSTAGING_REDIS_URL--asstill promotes toDATABASE_URL/REDIS_URLas before🤖 Generated with Claude Code