Server support for protocols - #26
Merged
Merged
Conversation
# Conflicts: # examples/echo/echos_tcp.py
Makes it run properly under netius that handles SSL disconnect in a different way
Uses the _asyncio_future_blocking to mark the object as duck type compatible
This makes it possible to use environment variables in Netius based event loops
This way it can be used by multiple clients
This support was added to the ServerTransport
Contributor
Author
|
There's still part of the server API that is pending implementation. |
joamag
force-pushed
the
protocols/server
branch
from
April 22, 2024 15:04
18e7181 to
8843d2d
Compare
Contributor
Author
|
Some initial notes on how to approach the challenge:
|
Contributor
Author
|
There should exist an immediate followup PR to re-open the on going work for server implementation. |
Contributor
Author
CC: @hugo-gomes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design changes
common.py(server(),socket_tcp(),socket_udp())compat.pyfileCurrent Status
EchoServerProtocol) already workingEchoProtocolis the one used for the testingWhat is still missing
Testing
To run the echo server Protocol implementation using netius run:
To use the compat version meaning that an asyncio-like interface will be used underneath the hoods use:
This PR is related to #23