fix: recognise quoted function names; cap instruction and label sizes - #5
Merged
Merged
Conversation
`"prompt_jev"(...)` was compared through the name's Display, which keeps the quotes, so a quoted call fell through to DataFusion as an unknown function. Match the bare identifier case-insensitively instead. Instructions over a few thousand characters are rejected by the provider with a bare HTTP status. Cap instructions at 4,000 characters, labels at 256, and descriptions at 1,024 during validation, so the caller sees the actual problem at plan time and no request is made. Found by fuzzing the SQL surface with 2,000 generated queries.
eddietejeda
requested review from
rohan-hotdata
and removed request for
a team
September 24, 2026 06:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from fuzzing the SQL surface (2,000 generated queries)
No internal errors, timeouts, or invariant violations. Two rough edges:
"prompt_jev"(...)with a quoted identifier was not recognised: the rewrite compared the name'sDisplay, which keeps the quotes, so the call reached DataFusion as an unknown function. It now matches the bare identifier case-insensitively. Schema-qualified names are still left to DataFusion.Tests
36 pass (2 new): quoted and uppercase names resolve to the same function; each size cap fails at plan time with no request made.