Skip to content

chore: add default CODEOWNERS #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddietejeda merged 1 commit into from
Aug 27, 2026
Merged

chore: add default CODEOWNERS #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @hotdata-dev/engineers

@claude claude Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider granting the team access before merging this (not blocking).

As the description notes, @hotdata-dev/engineers has no access to this repo yet. GitHub only honors code owners with write access, so until the gh api ... -f permission=push call is made this file is not just inert — GitHub's CODEOWNERS syntax check will render it as an error ("Unknown owner" / "does not have write access") on every PR page.

Two consequences worth weighing:

  • No reviews get auto-requested, which is the entire stated goal of the PR.
  • If this repo has, or later gains, a branch protection rule with Require review from Code Owners, an unresolvable owner makes that requirement unsatisfiable and PRs become unmergeable. I can't inspect branch protection settings from here, so please confirm that rule is off before merging if the access grant is going to lag.

Grant the team push first, then merge, and both concerns go away.

Loading