docs: move the open bug out of CLAUDE.md and into an issue - #57
Merged
Merged
Conversation
The file carried a "Known open issue" section describing the disk reclaim race. That is the same kind of expiring fact as the pinned commit id this file already dropped: whoever fixes the race will not think to edit a conventions document, so the section rots into a description of a bug that no longer exists, and an agent reading it wastes time on a solved problem — or worse, trusts the workaround it implies. A bug belongs in the tracker, where it can be assigned, discussed and closed. Filed as #56, with the sequence, the `t4` LSN ordering that makes the delete win, the generation-key fix and its consequence for `DiskResidue::superseded`, and the test that would close it. Replaced with what does not expire: open an issue, and read the open ones first, because this particular gap has been re-discovered more than once. Kept the mention of `DiskResidue`, `reclaim_orphaned_disk` and `settle` in the upstream-PR section. That is not a bug report — it is the durable fact that they are fork-only, which is what makes patches touching them unupstreamable. Re-checked against upstream: zero occurrences of each.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📊 Benchmark ComparisonCurrent:
Compared Liquid vs DataFusionDefault on the same runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE.mdhad a "Known open issue" section describing the disk reclaim race. That is the same class of mistake as the pinned commit id this file already dropped — a fact that expires.Whoever fixes the race will not think to edit a conventions document. The section then rots into a description of a bug that no longer exists, and the next agent either wastes time on a solved problem or trusts the workaround it implies.
Filed as #56 instead, with the sequence, the
t4LSN ordering that makes the stale delete win, the generation-key fix and its consequence forDiskResidue::superseded, and the deterministic test that would close it.What replaces it does not expire:
Kept the one remaining mention of
DiskResidue/reclaim_orphaned_disk/settle, in the upstream-PR section. That is not a bug report — it is the durable fact that they are fork-only, which is what makes a patch touching them unupstreamable. Re-checked against upstream: zero occurrences of each.